Skip to content

Fix feedreader tests broken by Python 3.14.3 asyncio changes#169080

Merged
justanotherariel merged 1 commit into
devfrom
feedreader/fix-test-broken-by-python-3.14.3-asyncio-changes
Apr 24, 2026
Merged

Fix feedreader tests broken by Python 3.14.3 asyncio changes#169080
justanotherariel merged 1 commit into
devfrom
feedreader/fix-test-broken-by-python-3.14.3-asyncio-changes

Conversation

@mib1185
Copy link
Copy Markdown
Member

@mib1185 mib1185 commented Apr 24, 2026

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the feedreader integration tests to be resilient to Python 3.14.3’s asyncio executor scheduling behavior, ensuring storage writes complete before assertions run.

Changes:

  • Add an explicit await hass.async_block_till_done() in the storage-writing test to flush the delayed storage save task before asserting on hass_storage.

@justanotherariel justanotherariel merged commit 599fe25 into dev Apr 24, 2026
37 checks passed
@justanotherariel justanotherariel deleted the feedreader/fix-test-broken-by-python-3.14.3-asyncio-changes branch April 24, 2026 16:49
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix feedreader tests broken by Python 3.14.3 asyncio changes

3 participants