Disable feedreader tests broken by Python 3.14.3 asyncio changes#169067
Disable feedreader tests broken by Python 3.14.3 asyncio changes#169067justanotherariel wants to merge 2 commits into
Conversation
home-assistant
Bot
added
cla-signed
has-tests
integration: dsmr
integration: feedreader
small-pr
|
Hey there @mib1185, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @RobBie1221, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
This PR aims to stop CI failures by skipping tests that have become flaky after Python 3.14.3 asyncio executor scheduling changes.
Changes:
- Skips
feedreaderstorage-writing test due to Python 3.14.3-related flakiness. - Skips DSMR setup and diagnostics tests for the same reported flakiness.
- Adds
pytestimport where needed to support the new skip marker.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tests/components/feedreader/test_init.py |
Skips test_storage_data_writing with a reason referencing Python 3.14.3 asyncio changes. |
tests/components/dsmr/test_sensor.py |
Skips test_default_setup with the same skip reason. |
tests/components/dsmr/test_diagnostics.py |
Imports pytest and skips test_diagnostics with the same skip reason. |
| @pytest.mark.skip( | ||
| reason="Flaky due to Python 3.14.3 asyncio changes - see home-assistant/core#162263" | ||
| ) |
There was a problem hiding this comment.
Make this skip conditional on the affected Python version(s) (e.g., via pytest.mark.skipif(sys.version_info >= ...)) so the test still runs on other Python versions and doesn’t permanently reduce coverage everywhere.
| @pytest.mark.skip( | ||
| reason="Flaky due to Python 3.14.3 asyncio changes - see home-assistant/core#162263" | ||
| ) |
There was a problem hiding this comment.
Update the PR title/description (or drop this change) since this PR also skips DSMR tests, not just the feedreader test mentioned in the PR metadata.
| @pytest.mark.skip( | ||
| reason="Flaky due to Python 3.14.3 asyncio changes - see home-assistant/core#162263" | ||
| ) |
There was a problem hiding this comment.
Consider making this skip conditional on the affected Python version(s) instead of unconditional, to avoid disabling diagnostics coverage on all Python versions.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
justanotherariel
force-pushed
the
disable-py3143-flaky-tests-feedreader
branch
from
4777b33 to
b26fd5e
Compare
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Thanks @mib1185. Closing then |
Breaking change
Proposed change
Disable flaky
feedreadertests that fail due to the Python 3.14.3 asyncio executor scheduling change (#162263).The following tests are affected:
tests/components/feedreader/test_init.py::test_storage_data_writingThese tests are marked with
@pytest.mark.xfailuntil codeowners can address the underlying timing issue. A tracking issue has been created for this: #169068.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: