Skip to content

Add explicit test of conditions.async_conditions_from_config#169042

Merged
arturpragacz merged 4 commits into
devfrom
add_conditions_from_config_test
Apr 28, 2026
Merged

Add explicit test of conditions.async_conditions_from_config#169042
arturpragacz merged 4 commits into
devfrom
add_conditions_from_config_test

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Add explicit test of conditions.async_conditions_from_config

Suggested here #169033 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a targeted unit test to ensure homeassistant.helpers.condition.async_conditions_from_config evaluates multiple conditions using AND semantics, complementing the recent migration work around ConditionChecker.

Changes:

  • Add a new test validating AND semantics for async_conditions_from_config.
  • Add logging import to support passing a logger into the helper under test.

Comment thread tests/helpers/test_condition.py Outdated
Comment thread tests/helpers/test_condition.py Outdated
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft April 24, 2026 13:07
Copilot AI review requested due to automatic review settings April 28, 2026 05:58
@emontnemery emontnemery marked this pull request as ready for review April 28, 2026 05:58
@home-assistant home-assistant Bot requested a review from arturpragacz April 28, 2026 05:58
@arturpragacz arturpragacz merged commit 8d5f83e into dev Apr 28, 2026
43 of 44 checks passed
@arturpragacz arturpragacz deleted the add_conditions_from_config_test branch April 28, 2026 06:24
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants