Skip to content

Migrate async_conditions_from_config to ConditionChecker#169033

Merged
emontnemery merged 8 commits into
devfrom
migrate_async_conditions_from_config
Apr 24, 2026
Merged

Migrate async_conditions_from_config to ConditionChecker#169033
emontnemery merged 8 commits into
devfrom
migrate_async_conditions_from_config

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Apr 24, 2026

Proposed change

Migrate async_conditions_from_config to ConditionChecker

The migrated conditions forward the async_unload calls to their children

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings April 24, 2026 08:08
@emontnemery emontnemery requested a review from a team as a code owner April 24, 2026 08:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates condition.async_conditions_from_config from returning a plain function to returning a ConditionChecker implementation so that lifecycle methods (notably async_unload) can be forwarded to child conditions.

Changes:

  • Update async_conditions_from_config to return a new ConditionsChecker (subclassing CompoundConditionChecker) instead of a closure.
  • Implement ConditionsChecker to AND child checks while logging warnings on ConditionError (matching previous behavior).
  • Add tests to verify async_unload forwarding for async_conditions_from_config, including nested compound conditions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
homeassistant/helpers/condition.py Introduces ConditionsChecker and changes async_conditions_from_config to return it.
tests/helpers/test_condition.py Adds coverage for async_unload forwarding behavior of async_conditions_from_config.

Comment thread homeassistant/helpers/condition.py Outdated
Comment thread homeassistant/helpers/condition.py Outdated
Copilot AI review requested due to automatic review settings April 24, 2026 09:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread tests/helpers/test_condition.py
Comment thread homeassistant/helpers/condition.py Outdated
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft April 24, 2026 10:44
Copilot AI review requested due to automatic review settings April 24, 2026 11:00
@emontnemery emontnemery marked this pull request as ready for review April 24, 2026 11:00
@home-assistant home-assistant Bot requested a review from arturpragacz April 24, 2026 11:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread homeassistant/helpers/condition.py Outdated
Comment thread homeassistant/helpers/condition.py Outdated
Comment thread homeassistant/helpers/condition.py Outdated
Comment thread homeassistant/helpers/condition.py
@home-assistant home-assistant Bot marked this pull request as draft April 24, 2026 11:43
Copilot AI review requested due to automatic review settings April 24, 2026 12:02
@emontnemery emontnemery marked this pull request as ready for review April 24, 2026 12:02
@home-assistant home-assistant Bot requested a review from arturpragacz April 24, 2026 12:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@emontnemery emontnemery merged commit db01b8e into dev Apr 24, 2026
52 checks passed
@emontnemery emontnemery deleted the migrate_async_conditions_from_config branch April 24, 2026 12:28
"""Condition checker that ANDs multiple conditions.

Used by automations and template entities. Unlike AndConditionChecker,
this logs warnings on errors instead of raising, and uses "condition"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe specify where the errors happen and are now caught? Looks like the change was done on unload.

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants