-
-
Notifications
You must be signed in to change notification settings - Fork 37.8k
Add a dynamic sensitivity slider for Matter sensors #167710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 22 commits
75468a1
fb120a7
1075942
f53ce2b
c158202
5227e80
354913b
d5978b4
561cd2c
d46e67f
4a65ed0
fa17bcd
4284ba3
4d09d6c
b5f1814
0cf7b22
375c7ca
a998a29
f7f0bd3
4c17644
e86f9f7
4bfa267
82e545f
ae41ef1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -560,11 +560,15 @@ def _update_from_device(self) -> None: | |
| clusters.PumpConfigurationAndControl.Attributes.OperationMode, | ||
| ), | ||
| ), | ||
| # Keep the legacy vendor-specific select entities around for one release | ||
| # so existing users can migrate before we remove them in favor of the | ||
| # generic number slider. | ||
| MatterDiscoverySchema( | ||
| platform=Platform.SELECT, | ||
| entity_description=MatterSelectEntityDescription( | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, let's deprecate the old select entities first by making them disabled by default. It should not cause any weird behavior. Both entities should update at the same time (if enabled). Though you need to add (I think due to how discovery works (first going through
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi, Thanks for the help! The test won't pass with the
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like you got everything figured out now, with tests passing. |
||
| key="AqaraBooleanStateConfigurationCurrentSensitivityLevel", | ||
| entity_category=EntityCategory.CONFIG, | ||
| entity_registry_enabled_default=False, | ||
| translation_key="sensitivity_level", | ||
| options=["10 mm", "20 mm", "30 mm"], | ||
| device_to_ha={ | ||
|
|
@@ -584,12 +588,14 @@ def _update_from_device(self) -> None: | |
| ), | ||
| vendor_id=(4447,), | ||
| product_id=(8194,), | ||
| allow_multi=True, | ||
| ), | ||
| MatterDiscoverySchema( | ||
| platform=Platform.SELECT, | ||
| entity_description=MatterSelectEntityDescription( | ||
| key="AqaraOccupancySensorBooleanStateConfigurationCurrentSensitivityLevel", | ||
| entity_category=EntityCategory.CONFIG, | ||
| entity_registry_enabled_default=False, | ||
| translation_key="sensitivity_level", | ||
| options=["low", "standard", "high"], | ||
| device_to_ha={ | ||
|
|
@@ -612,12 +618,14 @@ def _update_from_device(self) -> None: | |
| 8197, | ||
| 8195, | ||
| ), | ||
| allow_multi=True, | ||
| ), | ||
| MatterDiscoverySchema( | ||
| platform=Platform.SELECT, | ||
| entity_description=MatterSelectEntityDescription( | ||
| key="HeimanOccupancySensorBooleanStateConfigurationCurrentSensitivityLevel", | ||
| entity_category=EntityCategory.CONFIG, | ||
| entity_registry_enabled_default=False, | ||
| translation_key="sensitivity_level", | ||
| options=["low", "standard", "high"], | ||
| device_to_ha={ | ||
|
|
@@ -637,6 +645,7 @@ def _update_from_device(self) -> None: | |
| ), | ||
| vendor_id=(4619,), | ||
| product_id=(4097,), | ||
| allow_multi=True, | ||
| ), | ||
| MatterDiscoverySchema( | ||
| platform=Platform.SELECT, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.