-
-
Notifications
You must be signed in to change notification settings - Fork 37.6k
Add a dynamic sensitivity slider for Matter sensors #167710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
abmantis
merged 24 commits into
home-assistant:dev
from
wardmatter:codex/matter-sensitivity-slider
Apr 24, 2026
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
75468a1
Add dynamic Matter sensitivity slider discovery
wardmatter fb120a7
Make Matter sensitivity slider one-based
wardmatter 1075942
Format Matter select test
wardmatter f53ce2b
Regenerate Matter snapshots
wardmatter c158202
regenerate test files manually
wardmatter 5227e80
Merge branch 'dev' into codex/matter-sensitivity-slider
wardmatter 354913b
Restore Matter sensitivity selects for migration
wardmatter d5978b4
Merge remote-tracking branch 'upstream/dev' into codex/matter-sensiti…
wardmatter 561cd2c
Add Aqara multi-state P100 Matter fixture
wardmatter d46e67f
Add allow_multi to Matter legacy sensitivity selects
wardmatter 4a65ed0
Merge branch 'codex/matter-sensitivity-slider' of https://github.com/…
wardmatter fa17bcd
Restore Matter tests and enable legacy sensitivity selects
wardmatter 4284ba3
fix test
wardmatter 4d09d6c
Remove Matter custom component version
wardmatter b5f1814
Disable Matter legacy sensitivity selects by default
wardmatter 0cf7b22
enable select entity for aqara_door_window_p2 for testing
wardmatter 375c7ca
Merge branch 'dev' into codex/matter-sensitivity-slider
wardmatter a998a29
Merge branch 'dev' into codex/matter-sensitivity-slider
wardmatter f7f0bd3
Update homeassistant/components/matter/number.py
wardmatter 4c17644
Refine Matter sensitivity migration coverage
wardmatter e86f9f7
edit for cleaner diff of select.py
wardmatter 4bfa267
Format Matter P100 node fixture
wardmatter 82e545f
Update select.py comment
wardmatter ae41ef1
Merge branch 'dev' into codex/matter-sensitivity-slider
TheJulianJES File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's deprecate the old select entities first by making them disabled by default.
If you add
entity_registry_enabled_default=Falseto theMatterSelectEntityDescription, the old entities are disabled for newly paired devices, but still enabled on existing devices, since they might be used in automations there.It should not cause any weird behavior. Both entities should update at the same time (if enabled). Though you need to add
allow_multi=Trueto the number entity, so it doesn't "reserve" theCurrentSensitivityLevelattribute for itself, causing the oldSELECTentities to not be discovered.(I think due to how discovery works (first going through
NUMBER, thenSELECTschemas), it's enough to only addallow_multi=Trueto the number schemas, but let's also add it to theSELECTschemas as well to be a bit more consistent, and not depend on how the discovery order works.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thanks for the help!
The test won't pass with the
entity_registry_enabled_default=Falseadded, even the deviceaqara_door_window_p2works in real life with this PR. Should I touch thetest_selectas well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you got everything figured out now, with tests passing.
It's fine to add
entity_registry_enabled_by_defaultto thetest_selecttest, so the old entities are enabled by default for that test.