Skip to content

Add remaining cook time to vesync#160575

Closed
cdnninja wants to merge 5 commits into
home-assistant:devfrom
cdnninja:remainingTime
Closed

Add remaining cook time to vesync#160575
cdnninja wants to merge 5 commits into
home-assistant:devfrom
cdnninja:remainingTime

Conversation

@cdnninja
Copy link
Copy Markdown
Contributor

@cdnninja cdnninja commented Jan 9, 2026

Proposed change

Add remaining cook time to vesync.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 9, 2026

Hey there @markperdue, @webdjoe, @TheGardenMonkey, @iprak, @SapuSeven, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vesync can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vesync Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cdnninja
Copy link
Copy Markdown
Contributor Author

This is pending #160573

@cdnninja cdnninja marked this pull request as ready for review January 27, 2026 16:33
Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To double check -> Can you pause the device?

@cdnninja
Copy link
Copy Markdown
Contributor Author

@joostlek
Copy link
Copy Markdown
Member

Oh! Then should we make this a timestamp entity? As timestamps are always accurate. Then we can make the cook time go to either unknown or unavailable when paused for example

@cdnninja
Copy link
Copy Markdown
Contributor Author

We could calculate a rough timestamp. The API doesn't give one, we know the minutes remaining and the time we called the API. Right now by showing as a value in minutes and updating every 30 seconds we have a rough precision. I would think we could use a timestamp rounded to nearest minute though. Thoughts?

@joostlek
Copy link
Copy Markdown
Member

Yea that sounds cool! Please check Homewizard and starlink, who both have a way to ignore variance for the uptime entity

@cdnninja cdnninja marked this pull request as draft January 27, 2026 22:15
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions Bot added the stale label Mar 29, 2026
@github-actions github-actions Bot closed this Apr 6, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants