Add remaining cook time to vesync#160575
Conversation
|
Hey there @markperdue, @webdjoe, @TheGardenMonkey, @iprak, @SapuSeven, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
This is pending #160573 |
joostlek
left a comment
There was a problem hiding this comment.
To double check -> Can you pause the device?
|
When paused cook time remaining will revert to 0. https://github.com/webdjoe/pyvesync/blob/2f2511f27acc8162722f2bf2eee5e74134d07cdd/src/pyvesync/devices/vesynckitchen.py#L182-L184 cooking goes to "cookStop" |
|
Oh! Then should we make this a timestamp entity? As timestamps are always accurate. Then we can make the cook time go to either unknown or unavailable when paused for example |
|
We could calculate a rough timestamp. The API doesn't give one, we know the minutes remaining and the time we called the API. Right now by showing as a value in minutes and updating every 30 seconds we have a rough precision. I would think we could use a timestamp rounded to nearest minute though. Thoughts? |
|
Yea that sounds cool! Please check Homewizard and starlink, who both have a way to ignore variance for the uptime entity |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
Add remaining cook time to vesync.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: