Bump pyvesync to 3.4.1#160573
Conversation
|
Hey there @markperdue, @webdjoe, @TheGardenMonkey, @iprak, @SapuSeven, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
zweckj
left a comment
There was a problem hiding this comment.
mypy is failing, can you have a look?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Lots of changes to support the new exposed typing from the library. Let us know how you would like to proceed on this. |
|
The patch diff is strange since when I view it shows no files edited. I assume something went wrong with codecov. |
| VS_FAN_MODE_PRESET_LIST_HA = [ | ||
| VS_FAN_MODE_AUTO, | ||
| VS_FAN_MODE_SLEEP, | ||
| VS_FAN_MODE_ADVANCED_SLEEP, |
There was a problem hiding this comment.
Yes. Library converted that into sleep. It previously didn't work either way. It is fixed now.
| 'display_status': 'off', | ||
| 'friendly_name': 'SmartTowerFan', | ||
| 'mode': 'normal', | ||
| 'mode': <FanModes.NORMAL: 'normal'>, |
There was a problem hiding this comment.
@webdjoe it looks like just the smart tower fan changed how it presents modes in the library. No other device seems to do this.
There was a problem hiding this comment.
That's fine, it's still returned as a string
Breaking change
The
advanced_sleeppreset mode is now replaced bysleepProposed change
Bump pyvesync to 3.4.1. A few updates to keep experience the same. webdjoe/pyvesync@3.3.3...3.4.1
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: