Skip to content

Bump pyvesync to 3.4.1#160573

Merged
joostlek merged 24 commits into
home-assistant:devfrom
cdnninja:pyvesync3.4
Jan 27, 2026
Merged

Bump pyvesync to 3.4.1#160573
joostlek merged 24 commits into
home-assistant:devfrom
cdnninja:pyvesync3.4

Conversation

@cdnninja
Copy link
Copy Markdown
Contributor

@cdnninja cdnninja commented Jan 9, 2026

Breaking change

The advanced_sleep preset mode is now replaced by sleep

Proposed change

Bump pyvesync to 3.4.1. A few updates to keep experience the same. webdjoe/pyvesync@3.3.3...3.4.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 9, 2026

Hey there @markperdue, @webdjoe, @TheGardenMonkey, @iprak, @SapuSeven, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vesync can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vesync Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@epenet epenet changed the title bump pyvesync to 3.4.0 Bump pyvesync to 3.4.0 Jan 9, 2026
zweckj
zweckj previously requested changes Jan 9, 2026
Copy link
Copy Markdown
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mypy is failing, can you have a look?

@home-assistant home-assistant Bot marked this pull request as draft January 9, 2026 09:08
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 9, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@cdnninja cdnninja changed the title Bump pyvesync to 3.4.0 Bump pyvesync to 3.4.1 Jan 23, 2026
@cdnninja cdnninja marked this pull request as ready for review January 23, 2026 14:24
@home-assistant home-assistant Bot requested a review from zweckj January 23, 2026 14:24
@cdnninja
Copy link
Copy Markdown
Contributor Author

Lots of changes to support the new exposed typing from the library. Let us know how you would like to proceed on this.

@cdnninja cdnninja mentioned this pull request Jan 23, 2026
21 tasks
@cdnninja
Copy link
Copy Markdown
Contributor Author

The patch diff is strange since when I view it shows no files edited. I assume something went wrong with codecov.

Comment thread tests/components/vesync/snapshots/test_switch.ambr Outdated
VS_FAN_MODE_PRESET_LIST_HA = [
VS_FAN_MODE_AUTO,
VS_FAN_MODE_SLEEP,
VS_FAN_MODE_ADVANCED_SLEEP,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this removal intentional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Library converted that into sleep. It previously didn't work either way. It is fixed now.

Comment thread homeassistant/components/vesync/humidifier.py Outdated
Comment thread tests/components/vesync/snapshots/test_fan.ambr
@home-assistant home-assistant Bot marked this pull request as draft January 26, 2026 13:59
Copy link
Copy Markdown
Contributor

@home-assistant home-assistant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict.

@cdnninja cdnninja marked this pull request as ready for review January 27, 2026 01:09
@home-assistant home-assistant Bot requested a review from joostlek January 27, 2026 01:09
'display_status': 'off',
'friendly_name': 'SmartTowerFan',
'mode': 'normal',
'mode': <FanModes.NORMAL: 'normal'>,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webdjoe it looks like just the smart tower fan changed how it presents modes in the library. No other device seems to do this.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, it's still returned as a string

@joostlek joostlek merged commit f7bc7d3 into home-assistant:dev Jan 27, 2026
60 of 61 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants