Support KNX fan entity configuration from UI#159167
Merged
Merged
Conversation
Contributor
|
Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds UI configuration support for KNX fan entities, enabling users to configure fans through the Home Assistant UI instead of requiring YAML configuration. The implementation follows established patterns from other KNX platform entities like light, switch, and cover.
Key changes:
- Refactored the fan platform to support both YAML and UI configuration
- Added storage schema and UI strings for fan entity configuration
- Introduced support for two fan speed modes: percentage-based and step-based control
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/knx/const.py |
Added FanConf class for common fan config keys and included Platform.FAN in SUPPORTED_PLATFORMS_UI |
homeassistant/components/knx/schema.py |
Updated YAML schema to use FanConf.MAX_STEP instead of local constant for consistency |
homeassistant/components/knx/fan.py |
Refactored to support both UI and YAML configuration by splitting into KnxYamlFan and KnxUiFan classes with a common _KnxFan base class |
homeassistant/components/knx/storage/const.py |
Moved CONF_GA_STEP to common section (used by both cover and fan) and added fan-specific constants (CONF_SPEED, CONF_GA_SPEED, CONF_GA_OSCILLATION) |
homeassistant/components/knx/storage/entity_store_schema.py |
Added FAN_KNX_SCHEMA with GroupSelect for percentage vs step mode configuration |
homeassistant/components/knx/strings.json |
Added comprehensive user-facing strings for fan configuration UI with descriptions for all options |
tests/components/knx/test_fan.py |
Updated existing tests to use FanConf.MAX_STEP and added new parametrized tests for UI creation and storage loading |
tests/components/knx/fixtures/config_store_fan.json |
Added test fixture with two fan configurations (step mode with oscillation and percentage mode) |
joostlek
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Support KNX fan entity configuration from UI
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: