Skip to content

Support KNX fan entity configuration from UI#159167

Merged
joostlek merged 5 commits into
devfrom
knx-ui-fan
Dec 18, 2025
Merged

Support KNX fan entity configuration from UI#159167
joostlek merged 5 commits into
devfrom
knx-ui-fan

Conversation

@farmio
Copy link
Copy Markdown
Member

@farmio farmio commented Dec 16, 2025

Proposed change

Support KNX fan entity configuration from UI

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of knx can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign knx Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds UI configuration support for KNX fan entities, enabling users to configure fans through the Home Assistant UI instead of requiring YAML configuration. The implementation follows established patterns from other KNX platform entities like light, switch, and cover.

Key changes:

  • Refactored the fan platform to support both YAML and UI configuration
  • Added storage schema and UI strings for fan entity configuration
  • Introduced support for two fan speed modes: percentage-based and step-based control

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
homeassistant/components/knx/const.py Added FanConf class for common fan config keys and included Platform.FAN in SUPPORTED_PLATFORMS_UI
homeassistant/components/knx/schema.py Updated YAML schema to use FanConf.MAX_STEP instead of local constant for consistency
homeassistant/components/knx/fan.py Refactored to support both UI and YAML configuration by splitting into KnxYamlFan and KnxUiFan classes with a common _KnxFan base class
homeassistant/components/knx/storage/const.py Moved CONF_GA_STEP to common section (used by both cover and fan) and added fan-specific constants (CONF_SPEED, CONF_GA_SPEED, CONF_GA_OSCILLATION)
homeassistant/components/knx/storage/entity_store_schema.py Added FAN_KNX_SCHEMA with GroupSelect for percentage vs step mode configuration
homeassistant/components/knx/strings.json Added comprehensive user-facing strings for fan configuration UI with descriptions for all options
tests/components/knx/test_fan.py Updated existing tests to use FanConf.MAX_STEP and added new parametrized tests for UI creation and storage loading
tests/components/knx/fixtures/config_store_fan.json Added test fixture with two fan configurations (step mode with oscillation and percentage mode)

Comment thread homeassistant/components/knx/fan.py Outdated
@joostlek joostlek merged commit 3c865c6 into dev Dec 18, 2025
36 checks passed
@joostlek joostlek deleted the knx-ui-fan branch December 18, 2025 14:54
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants