Skip to content

Bump aiodns to 3.6.1#159073

Merged
edenhaus merged 3 commits into
home-assistant:devfrom
mithomas:aiodns-3.6.1
Dec 15, 2025
Merged

Bump aiodns to 3.6.1#159073
edenhaus merged 3 commits into
home-assistant:devfrom
mithomas:aiodns-3.6.1

Conversation

@mithomas
Copy link
Copy Markdown
Contributor

Proposed change

Bump aiodns to version 3.6.1 to avoid breaking tests due to aio-libs/aiodns#214.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

See also relevant dependency changelog: https://github.com/aio-libs/aiodns/releases/tag/v3.6.1

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@mithomas mithomas requested review from a team and gjohansson-ST as code owners December 15, 2025 09:10
Copy link
Copy Markdown
Contributor

@home-assistant home-assistant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mithomas

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant Bot added cla-needed core dependency Pull requests marked as a dependency upgrade integration: dnsip small-pr PRs with less than 30 lines. labels Dec 15, 2025
@home-assistant home-assistant Bot marked this pull request as draft December 15, 2025 09:11
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @gjohansson-ST, mind taking a look at this pull request as it has been labeled with an integration (dnsip) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of dnsip can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign dnsip Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mithomas mithomas marked this pull request as ready for review December 15, 2025 09:14
Copy link
Copy Markdown
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mithomas 👍

Can be merged when CI is green

@sairon
Copy link
Copy Markdown
Member

sairon commented Dec 15, 2025

The test failure seems unrelated but it should be noted that this bump makes #158695 redundant, so we should consider reverting it.

@edenhaus edenhaus merged commit f640795 into home-assistant:dev Dec 15, 2025
115 of 120 checks passed
@edenhaus edenhaus added this to the 2025.12.4 milestone Dec 15, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed core dependency Pull requests marked as a dependency upgrade integration: dnsip Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants