Pin pycares to 4.11.0#158695
Conversation
pycares 5.0 was released which is not compatible with aiodns yet
|
Going to look at getting aiodns updated tomorrow Just landing from Frankfurt in Houston after multiple delays so too useless to do it tonight |
There was a problem hiding this comment.
Pull request overview
This PR pins the pycares package to version 4.11.0 to prevent compatibility issues with aiodns that arise from the newly released pycares 5.0. The constraint ensures that Home Assistant continues to function properly with integrations that depend on aiodns (such as the DNS IP and Radio Browser integrations).
Key changes:
- Added version pin for pycares==4.11.0 with explanatory comment in both constraint files
- Follows the established pattern for pinning dependencies in Home Assistant
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| script/gen_requirements_all.py | Added pycares==4.11.0 constraint to CONSTRAINT_BASE string, which is used to generate package_constraints.txt |
| homeassistant/package_constraints.txt | Added pycares==4.11.0 constraint with explanatory comment about aiodns compatibility |
After thoroughly reviewing this pull request, I found no issues with the implementation. The changes are:
✅ Correctly formatted - Both files follow the existing pattern for pinning dependencies with clear explanatory comments
✅ Consistent - The constraint and comment are identical in both files
✅ Well-placed - Added at the end of the constraint sections in both files, maintaining alphabetical grouping
✅ Properly documented - The comment clearly explains the reason for the pin ("pycares 5.x is not yet compatible with aiodns")
The approach is appropriate for handling a transitive dependency issue (pycares is a dependency of aiodns, not directly used by Home Assistant integrations).
|
aiodns 3.6.1 properly pins its pycares dependency (including a major version bracket) so updating aiodns might be the more suitable fix. |
|
Please see aio-libs/aiodns#218 |
Proposed change
pycares 5.0 was released which is not compatible with aiodns yet
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: