Skip to content

Pin pycares to 4.11.0#158695

Merged
balloob merged 1 commit into
devfrom
pin_pycares
Dec 11, 2025
Merged

Pin pycares to 4.11.0#158695
balloob merged 1 commit into
devfrom
pin_pycares

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Dec 11, 2025

Proposed change

pycares 5.0 was released which is not compatible with aiodns yet

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

pycares 5.0 was released which is not compatible with aiodns yet
@bdraco bdraco added this to the 2025.12.3 milestone Dec 11, 2025
@home-assistant home-assistant Bot added cla-signed core dependency Pull requests marked as a dependency upgrade small-pr PRs with less than 30 lines. labels Dec 11, 2025
@bdraco bdraco marked this pull request as ready for review December 11, 2025 00:51
Copilot AI review requested due to automatic review settings December 11, 2025 00:51
@bdraco bdraco requested a review from a team as a code owner December 11, 2025 00:51
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 11, 2025

Going to look at getting aiodns updated tomorrow

aio-libs/aiodns#214 (comment)

Just landing from Frankfurt in Houston after multiple delays so too useless to do it tonight

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR pins the pycares package to version 4.11.0 to prevent compatibility issues with aiodns that arise from the newly released pycares 5.0. The constraint ensures that Home Assistant continues to function properly with integrations that depend on aiodns (such as the DNS IP and Radio Browser integrations).

Key changes:

  • Added version pin for pycares==4.11.0 with explanatory comment in both constraint files
  • Follows the established pattern for pinning dependencies in Home Assistant

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
script/gen_requirements_all.py Added pycares==4.11.0 constraint to CONSTRAINT_BASE string, which is used to generate package_constraints.txt
homeassistant/package_constraints.txt Added pycares==4.11.0 constraint with explanatory comment about aiodns compatibility

After thoroughly reviewing this pull request, I found no issues with the implementation. The changes are:

Correctly formatted - Both files follow the existing pattern for pinning dependencies with clear explanatory comments
Consistent - The constraint and comment are identical in both files
Well-placed - Added at the end of the constraint sections in both files, maintaining alphabetical grouping
Properly documented - The comment clearly explains the reason for the pin ("pycares 5.x is not yet compatible with aiodns")

The approach is appropriate for handling a transitive dependency issue (pycares is a dependency of aiodns, not directly used by Home Assistant integrations).

@balloob balloob merged commit 69c7a7b into dev Dec 11, 2025
72 of 73 checks passed
@balloob balloob deleted the pin_pycares branch December 11, 2025 03:01
@xrad
Copy link
Copy Markdown

xrad commented Dec 11, 2025

aiodns 3.6.1 properly pins its pycares dependency (including a major version bracket) so updating aiodns might be the more suitable fix.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 11, 2025

Please see aio-libs/aiodns#218

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed core dependency Pull requests marked as a dependency upgrade small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants