Skip to content

Fix Tuya BitmapTypeInformation parsing #158474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epenet merged 1 commit into from
Dec 9, 2025
+248 −2
Merged

Fix Tuya BitmapTypeInformation parsing #158474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions homeassistant/components/tuya/type_information.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,12 @@ class BitmapTypeInformation(TypeInformation[int]):
@classmethod
def _from_json(cls, dpcode: str, type_data: str) -> Self | None:
"""Load JSON string and return a BitmapTypeInformation object."""
if not (parsed := json_loads_object(type_data)):
if not (parsed := cast(dict[str, Any] | None, json_loads_object(type_data))):
return None
return cls(
dpcode=dpcode,
type_data=type_data,
**cast(dict[str, list[str]], parsed),
label=parsed["label"],
)


Expand Down
54 changes: 54 additions & 0 deletions tests/components/tuya/fixtures/msp_5t7esmqqh92ssbe5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
{
"endpoint": "https://apigw.tuyaeu.com",
"mqtt_connected": true,
"disabled_by": null,
"disabled_polling": false,
"name": "Slimme kattenbak",
"category": "msp",
"product_id": "5t7esmqqh92ssbe5",
"product_name": "Automatic Cat Litter Box",
"online": false,
"sub": false,
"time_zone": "+02:00",
"active_time": "2025-07-25T06:46:38+00:00",
"create_time": "2025-07-25T06:46:38+00:00",
"update_time": "2025-07-25T06:46:38+00:00",
"function": {
"deodorization": {
"type": "Boolean",
"value": "{}"
}
},
"status_range": {
"cat_weight": {
"type": "Integer",
"value": "{\"unit\":\"g\",\"min\":600,\"max\":10000,\"scale\":0,\"step\":1}"
},
"excretion_times_day": {
"type": "Integer",
"value": "{\"unit\":\"times\",\"min\":0,\"max\":60,\"scale\":0,\"step\":1}"
},
"excretion_time_day": {
"type": "Integer",
"value": "{\"unit\":\"s\",\"min\":0,\"max\":1800,\"scale\":0,\"step\":1}"
},
"deodorization": {
"type": "Boolean",
"value": "{}"
},
"fault": {
"type": "Bitmap",
"value": "{\"label\":[\"motor_fault\",\"program_fault\",\"g_sensor_fault\"],\"maxlen\":3}"
}
},
"status": {
"cat_weight": 4999,
"excretion_times_day": 1,
"excretion_time_day": 93,
"deodorization": false,
"fault": 0
},
"set_up": true,
"support_local": true,
"warnings": null
}
31 changes: 31 additions & 0 deletions tests/components/tuya/snapshots/test_init.ambr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,37 @@
'via_device_id': None,
})
# ---
# name: test_device_registry[5ebss29hqqmse7t5psm]
DeviceRegistryEntrySnapshot({
'area_id': None,
'config_entries': <ANY>,
'config_entries_subentries': <ANY>,
'configuration_url': None,
'connections': set({
}),
'disabled_by': None,
'entry_type': None,
'hw_version': None,
'id': <ANY>,
'identifiers': set({
tuple(
'tuya',
'5ebss29hqqmse7t5psm',
),
}),
'labels': set({
}),
'manufacturer': 'Tuya',
'model': 'Automatic Cat Litter Box',
'model_id': '5t7esmqqh92ssbe5',
'name': 'Slimme kattenbak',
'name_by_user': None,
'primary_config_entry': <ANY>,
'serial_number': None,
'sw_version': None,
'via_device_id': None,
})
# ---
# name: test_device_registry[5gfyvvg48bsxbbnjzc]
DeviceRegistryEntrySnapshot({
'area_id': None,
Expand Down
161 changes: 161 additions & 0 deletions tests/components/tuya/snapshots/test_sensor.ambr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16914,6 +16914,167 @@
'state': '77.0',
})
# ---
# name: test_platform_setup_and_discovery[sensor.slimme_kattenbak_cat_weight-entry]
EntityRegistryEntrySnapshot({
'aliases': set({
}),
'area_id': None,
'capabilities': dict({
'state_class': <SensorStateClass.MEASUREMENT: 'measurement'>,
}),
'config_entry_id': <ANY>,
'config_subentry_id': <ANY>,
'device_class': None,
'device_id': <ANY>,
'disabled_by': None,
'domain': 'sensor',
'entity_category': None,
'entity_id': 'sensor.slimme_kattenbak_cat_weight',
'has_entity_name': True,
'hidden_by': None,
'icon': None,
'id': <ANY>,
'labels': set({
}),
'name': None,
'options': dict({
'sensor': dict({
'suggested_display_precision': 0,
}),
}),
'original_device_class': <SensorDeviceClass.WEIGHT: 'weight'>,
'original_icon': None,
'original_name': 'Cat weight',
'platform': 'tuya',
'previous_unique_id': None,
'suggested_object_id': None,
'supported_features': 0,
'translation_key': 'cat_weight',
'unique_id': 'tuya.5ebss29hqqmse7t5psmcat_weight',
'unit_of_measurement': 'g',
})
# ---
# name: test_platform_setup_and_discovery[sensor.slimme_kattenbak_cat_weight-state]
StateSnapshot({
'attributes': ReadOnlyDict({
'device_class': 'weight',
'friendly_name': 'Slimme kattenbak Cat weight',
'state_class': <SensorStateClass.MEASUREMENT: 'measurement'>,
'unit_of_measurement': 'g',
}),
'context': <ANY>,
'entity_id': 'sensor.slimme_kattenbak_cat_weight',
'last_changed': <ANY>,
'last_reported': <ANY>,
'last_updated': <ANY>,
'state': 'unavailable',
})
# ---
# name: test_platform_setup_and_discovery[sensor.slimme_kattenbak_excretion_duration-entry]
EntityRegistryEntrySnapshot({
'aliases': set({
}),
'area_id': None,
'capabilities': dict({
'state_class': <SensorStateClass.MEASUREMENT: 'measurement'>,
}),
'config_entry_id': <ANY>,
'config_subentry_id': <ANY>,
'device_class': None,
'device_id': <ANY>,
'disabled_by': None,
'domain': 'sensor',
'entity_category': None,
'entity_id': 'sensor.slimme_kattenbak_excretion_duration',
'has_entity_name': True,
'hidden_by': None,
'icon': None,
'id': <ANY>,
'labels': set({
}),
'name': None,
'options': dict({
'sensor': dict({
'suggested_display_precision': 2,
}),
}),
'original_device_class': <SensorDeviceClass.DURATION: 'duration'>,
'original_icon': None,
'original_name': 'Excretion duration',
'platform': 'tuya',
'previous_unique_id': None,
'suggested_object_id': None,
'supported_features': 0,
'translation_key': 'excretion_time_day',
'unique_id': 'tuya.5ebss29hqqmse7t5psmexcretion_time_day',
'unit_of_measurement': 's',
})
# ---
# name: test_platform_setup_and_discovery[sensor.slimme_kattenbak_excretion_duration-state]
StateSnapshot({
'attributes': ReadOnlyDict({
'device_class': 'duration',
'friendly_name': 'Slimme kattenbak Excretion duration',
'state_class': <SensorStateClass.MEASUREMENT: 'measurement'>,
'unit_of_measurement': 's',
}),
'context': <ANY>,
'entity_id': 'sensor.slimme_kattenbak_excretion_duration',
'last_changed': <ANY>,
'last_reported': <ANY>,
'last_updated': <ANY>,
'state': 'unavailable',
})
# ---
# name: test_platform_setup_and_discovery[sensor.slimme_kattenbak_excretion_times_day-entry]
EntityRegistryEntrySnapshot({
'aliases': set({
}),
'area_id': None,
'capabilities': None,
'config_entry_id': <ANY>,
'config_subentry_id': <ANY>,
'device_class': None,
'device_id': <ANY>,
'disabled_by': None,
'domain': 'sensor',
'entity_category': None,
'entity_id': 'sensor.slimme_kattenbak_excretion_times_day',
'has_entity_name': True,
'hidden_by': None,
'icon': None,
'id': <ANY>,
'labels': set({
}),
'name': None,
'options': dict({
}),
'original_device_class': None,
'original_icon': None,
'original_name': 'Excretion times (day)',
'platform': 'tuya',
'previous_unique_id': None,
'suggested_object_id': None,
'supported_features': 0,
'translation_key': 'excretion_times_day',
'unique_id': 'tuya.5ebss29hqqmse7t5psmexcretion_times_day',
'unit_of_measurement': 'times',
})
# ---
# name: test_platform_setup_and_discovery[sensor.slimme_kattenbak_excretion_times_day-state]
StateSnapshot({
'attributes': ReadOnlyDict({
'friendly_name': 'Slimme kattenbak Excretion times (day)',
'unit_of_measurement': 'times',
}),
'context': <ANY>,
'entity_id': 'sensor.slimme_kattenbak_excretion_times_day',
'last_changed': <ANY>,
'last_reported': <ANY>,
'last_updated': <ANY>,
'state': 'unavailable',
})
# ---
# name: test_platform_setup_and_discovery[sensor.smart_odor_eliminator_pro_battery-entry]
EntityRegistryEntrySnapshot({
'aliases': set({
Expand Down
Loading