Fix Tuya BitmapTypeInformation parsing#158474
Merged
Merged
Conversation
Contributor
|
Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
approved these changes
Dec 9, 2025
This was referenced Dec 9, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Tuya integration's BitmapTypeInformation parsing. The issue occurred when parsing JSON data containing bitmap type information with multiple fields - the old code attempted to unpack all JSON keys as constructor arguments, but the BitmapTypeInformation dataclass only accepts a label field, causing a TypeError when additional keys like maxlen were present.
Key Changes
- Fixed
BitmapTypeInformation._from_jsonto explicitly extract only thelabelfield instead of unpacking the entire parsed dictionary - Added type cast for improved type checking consistency with other type information classes
- Added test fixture for automatic cat litter box device (
msp_5t7esmqqh92ssbe5.json) that includes bitmap type data with multiple fields
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/tuya/type_information.py |
Fixed BitmapTypeInformation parsing to extract only the label field instead of unpacking all dictionary keys |
tests/components/tuya/fixtures/msp_5t7esmqqh92ssbe5.json |
Added test fixture for cat litter box device with bitmap fault status containing label and maxlen fields |
tests/components/tuya/snapshots/test_sensor.ambr |
Added snapshots for three new sensor entities from the cat litter box device fixture |
tests/components/tuya/snapshots/test_init.ambr |
Added device registry snapshot for the cat litter box device |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
As spotted in #158463
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: