Skip to content

Fix Tuya BitmapTypeInformation parsing#158474

Merged
epenet merged 1 commit into
devfrom
epenet-20251209-1724
Dec 9, 2025
Merged

Fix Tuya BitmapTypeInformation parsing#158474
epenet merged 1 commit into
devfrom
epenet-20251209-1724

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Dec 9, 2025

Proposed change

As spotted in #158463

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings December 9, 2025 16:28
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Dec 9, 2025

Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the Tuya integration's BitmapTypeInformation parsing. The issue occurred when parsing JSON data containing bitmap type information with multiple fields - the old code attempted to unpack all JSON keys as constructor arguments, but the BitmapTypeInformation dataclass only accepts a label field, causing a TypeError when additional keys like maxlen were present.

Key Changes

  • Fixed BitmapTypeInformation._from_json to explicitly extract only the label field instead of unpacking the entire parsed dictionary
  • Added type cast for improved type checking consistency with other type information classes
  • Added test fixture for automatic cat litter box device (msp_5t7esmqqh92ssbe5.json) that includes bitmap type data with multiple fields

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
homeassistant/components/tuya/type_information.py Fixed BitmapTypeInformation parsing to extract only the label field instead of unpacking all dictionary keys
tests/components/tuya/fixtures/msp_5t7esmqqh92ssbe5.json Added test fixture for cat litter box device with bitmap fault status containing label and maxlen fields
tests/components/tuya/snapshots/test_sensor.ambr Added snapshots for three new sensor entities from the cat litter box device fixture
tests/components/tuya/snapshots/test_init.ambr Added device registry snapshot for the cat litter box device

@epenet epenet merged commit 61499a5 into dev Dec 9, 2025
41 of 42 checks passed
@epenet epenet deleted the epenet-20251209-1724 branch December 9, 2025 16:39
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants