Make Tuya find_dpcode a class method#158028
Merged
Merged
Conversation
Contributor
|
Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the Tuya integration's type information system by converting the module-level find_dpcode function into a class method on the TypeInformation base class. This is a code quality improvement that makes the architecture cleaner and more object-oriented.
Key Changes
- Moved
find_dpcodefrom a module-level function to a class method onTypeInformation - Introduced
_DPTYPEas aClassVar[DPType]on eachTypeInformationsubclass to identify the DPType - Created explicit classes for previously generic type information:
JsonTypeInformation,RawTypeInformation, andStringTypeInformation - Updated all wrapper classes in
models.pyto reference type information classes instead ofDPTypeenum values
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| homeassistant/components/tuya/type_information.py | Refactored find_dpcode to be a class method, added _DPTYPE ClassVar to all type information classes, created new type information classes for JSON/Raw/String types, removed old module-level function |
| homeassistant/components/tuya/models.py | Updated all wrapper classes to use type information classes for _DPTYPE, changed find_dpcode calls to use class methods |
| homeassistant/components/tuya/sensor.py | Updated _WindDirectionWrapper to use EnumTypeInformation class instead of DPType.ENUM |
tsvi
reviewed
Dec 5, 2025
thecode
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
SSIA
Means we can drop all the
@overloadType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: