VeSync strict-typing#157797
Conversation
|
Hey there @markperdue, @webdjoe, @TheGardenMonkey, @iprak, @SapuSeven, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
epenet
left a comment
There was a problem hiding this comment.
It seems that pyvesync has type information, but does not expose it outside of the project.
I think it's missing py.typed marker.
You should resolve that before enabling strict-typing in Home Assistant.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
This is pending #160573 |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
Enable strict typing. While this is a higher level for the quality scale I figured sooner I enable it mean less re-work later. #156663
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: