Skip to content

Correctcurrent_temp local variable name in homekit _get_current_temperature#157202

Merged
frenck merged 2 commits into
home-assistant:devfrom
ndrwrbgs:rename
Nov 25, 2025
Merged

Correctcurrent_temp local variable name in homekit _get_current_temperature#157202
frenck merged 2 commits into
home-assistant:devfrom
ndrwrbgs:rename

Conversation

@ndrwrbgs
Copy link
Copy Markdown
Contributor

@ndrwrbgs ndrwrbgs commented Nov 24, 2025

🙏 Thank you maintainers for your time and commitment to FOSS! 💖

Proposed change

Typo in _get_current_temperature. Relevance: I was looking for the current temp and my learned workflow made it difficult to discover due to the misnomer. Just updating the copy-paste from the method above to match the intent. Non-functional change.

It looks like copy-paste from _get_target_temperature Name chosen to pattern-match _get_target_temperature.target_temp -> _get_current_temperature.current_temp

👉 NOTE ⏱️Following this template accurately and in earnest added 2 hours to a 1 minute change. Most of that due to test latency & doing PRs, even with those being done in parallel - no open PRs were as trivial as this one. Of course, no change should be assumed to be 1 minute, but the 2 hours did seem in reducible excess. Happy and eager to help reduce that wherever there's appetite and interest!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

@`maintainers: Should the PR template for this section direct(/permit, given the text at the very top ["DO NOT DELETE ANY TEXT from this template! (unless instructed)"]) us to remove those items in this list which are not applicable rather than leaving them empty (re "Please be sure to fill out additional details, if applicable")

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested✅ and works locally ❌.
  • ⚠️Local tests pass. Your PR cannot be merged unless tests pass
    • No, they did not pass, but the failures were unrelated other plugins and seemed like things like flakey tests and async bugs. @'maintainers - should there be a different process for these or this line be updated to modify the local testing to be scoped to the component being changed?
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
    • This doc requires testing, so https://developers.home-assistant.io/docs/development_testing was followed
    • ❓"To run our linters, on the full code base, run the following command": The directed pre-commit run --all-files had many errors, none seemed related to this change but due to the volume it was difficult to tell
    • uv pip install -r requirements_test_all.txt -> "warning: The package typer==0.12.5 does not have an extra named all"
    • ❓pytest - run, but failed; seemed unrelated again but due to the volume of failures it was difficult to tell
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • [N/A] Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

"If the code communicates with devices" -> ❓I guess that in nature it does, but not in the context of this change? Either way these items seem targeted for a different type of change.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (homekit) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homekit can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homekit Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Nov 24, 2025

Would you please cleanup the PR summary. The template is a bit mangled

@ndrwrbgs
Copy link
Copy Markdown
Contributor Author

What issue are you seeing?

@ndrwrbgs
Copy link
Copy Markdown
Contributor Author

Ope! @bdraco In another browser I saw that there was one list under "If the code communicates with devices" that got 2-line newlines rather than 1-line, fixed now.

Apologies for the extra whitespace 😳. 🥺 Github markdown thought that follow up item was part of the previous list

@bdraco bdraco changed the title [Typo] Correct/update current_temp local variable Correctcurrent_temp local variable name in homekit _get_current_temperature Nov 24, 2025
@ndrwrbgs
Copy link
Copy Markdown
Contributor Author

@bdraco 🥳🙏 Thank you so much!

I think HA owns the template and developer docs, right? If that's true, are you homekit or home-assistant-general?

If the later, is there anything from the notes that I might help with or a good place to move them for tracking? If the former, is there a good way/place to get the later's 👀 on the contributing issues experienced.

I would love to (meta) contribute to the contributing ease/speed/experience!

@frenck frenck merged commit f82f0a1 into home-assistant:dev Nov 25, 2025
36 checks passed
@ndrwrbgs ndrwrbgs deleted the rename branch November 25, 2025 05:14
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants