Skip to content

Remove the restriction that Bluetooth login to the Switchbot account is only possible in active mode#157154

Merged
joostlek merged 3 commits into
home-assistant:devfrom
zerzhang:feature/remove_active_mode_restrictions
Dec 15, 2025
Merged

Remove the restriction that Bluetooth login to the Switchbot account is only possible in active mode#157154
joostlek merged 3 commits into
home-assistant:devfrom
zerzhang:feature/remove_active_mode_restrictions

Conversation

@zerzhang
Copy link
Copy Markdown
Contributor

@zerzhang zerzhang commented Nov 24, 2025

Proposed change

  • Even when Bluetooth is in passive mode, it allows users to sync device types by logging in with their account, which should be helpful when adding sensor categories.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @Danielhiversen, @RenierM26, @murtas, @Eloston, @dsypniewski, mind taking a look at this pull request as it has been labeled with an integration (switchbot) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switchbot can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switchbot Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

@ndrwrbgs ndrwrbgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ The change itself looks fine, though leaves some potentially removeable code.

❓Would it be useful to add a test that the change did what was intended? If so, the "remove/dead-code" comments in the test file would be negated since that code would be used for such a test.

"Why are you reviewing my change?"

- [ ] I have reviewed two other [open pull requests][prs] in this repository.

Comment thread tests/components/switchbot/test_config_flow.py Outdated
Comment thread homeassistant/components/switchbot/config_flow.py
@bdraco bdraco changed the title Remove the restriction that Bluetooth login to the Switchbot account is only possible in active mode. Remove the restriction that Bluetooth login to the Switchbot account is only possible in active mode Nov 24, 2025
@joostlek joostlek merged commit 47f476a into home-assistant:dev Dec 15, 2025
36 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 16, 2025
@zerzhang zerzhang deleted the feature/remove_active_mode_restrictions branch March 19, 2026 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants