-
-
Notifications
You must be signed in to change notification settings - Fork 37.5k
Add quality scale for GIOS #155603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quality scale for GIOS #155603
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| rules: | ||
| # Other comments: | ||
| # - we could consider removing the air quality entity removal | ||
|
|
||
| # Bronze | ||
| action-setup: | ||
| status: exempt | ||
| comment: No custom actions are defined. | ||
| appropriate-polling: done | ||
| brands: done | ||
| common-modules: done | ||
| config-flow-test-coverage: | ||
| status: todo | ||
| comment: | ||
| We should have the happy flow as the first test, which can be merged with test_show_form. | ||
| The config flow tests are missing adding a duplicate entry test. | ||
| config-flow: | ||
| status: todo | ||
| comment: Limit the scope of the try block in the user step | ||
| dependency-transparency: done | ||
| docs-actions: | ||
| status: exempt | ||
| comment: No custom actions are defined. | ||
| docs-high-level-description: done | ||
| docs-installation-instructions: done | ||
| docs-removal-instructions: done | ||
| entity-event-setup: done | ||
| entity-unique-id: done | ||
| has-entity-name: done | ||
| runtime-data: | ||
| status: todo | ||
| comment: No direct need to wrap the coordinator in a dataclass to store in the config entry | ||
| test-before-configure: done | ||
| test-before-setup: done | ||
| unique-config-entry: done | ||
|
|
||
| # Silver | ||
| action-exceptions: | ||
| status: exempt | ||
| comment: No custom actions are defined. | ||
| config-entry-unloading: done | ||
| docs-configuration-parameters: | ||
| status: exempt | ||
| comment: No options flow | ||
| docs-installation-parameters: done | ||
| entity-unavailable: done | ||
| integration-owner: done | ||
| log-when-unavailable: done | ||
| parallel-updates: done | ||
| reauthentication-flow: | ||
| status: exempt | ||
| comment: This integration does not require authentication. | ||
| test-coverage: | ||
| status: todo | ||
| comment: | ||
| The `test_async_setup_entry` should test the state of the mock config entry, instead of an entity state | ||
| The `test_availability` doesn't really do what it says it does, and this is now already tested via the snapshot tests. | ||
|
|
||
| # Gold | ||
| devices: done | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we actually cache the name in the entry data instead of using the up to date name?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Previously, With the changes introduced in #155762, the integration now always uses the value stored in This makes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wouldn't really consider downgrading a use case, but this is a nice food for thought |
||
| diagnostics: done | ||
| discovery-update-info: | ||
| status: exempt | ||
| comment: This integration is a cloud service and thus does not support discovery. | ||
| discovery: | ||
| status: exempt | ||
| comment: This integration is a cloud service and thus does not support discovery. | ||
| docs-data-update: done | ||
| docs-examples: done | ||
| docs-known-limitations: done | ||
|
mik-laj marked this conversation as resolved.
|
||
| docs-supported-devices: | ||
| status: exempt | ||
| comment: This is an service, which doesn't integrate with any devices. | ||
| docs-supported-functions: done | ||
| docs-troubleshooting: done | ||
| docs-use-cases: done | ||
| dynamic-devices: | ||
| status: exempt | ||
| comment: This integration does not have devices. | ||
| entity-category: done | ||
| entity-device-class: | ||
| status: todo | ||
| comment: We can use the CO device class for the carbon monoxide sensor | ||
| entity-disabled-by-default: done | ||
| entity-translations: | ||
| status: todo | ||
| comment: We can remove the options state_attributes. | ||
| exception-translations: done | ||
| icon-translations: done | ||
| reconfiguration-flow: | ||
|
mik-laj marked this conversation as resolved.
|
||
| status: exempt | ||
| comment: Only parameter that could be changed station_id would force a new config entry. | ||
| repair-issues: done | ||
| stale-devices: | ||
| status: exempt | ||
| comment: This integration does not have devices. | ||
|
|
||
| # Platinum | ||
| async-dependency: done | ||
| inject-websession: done | ||
| strict-typing: done | ||
Uh oh!
There was an error while loading. Please reload this page.