Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 101 additions & 0 deletions homeassistant/components/gios/quality_scale.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
rules:
Comment thread
mik-laj marked this conversation as resolved.
# Other comments:
# - we could consider removing the air quality entity removal

# Bronze
action-setup:
status: exempt
comment: No custom actions are defined.
appropriate-polling: done
brands: done
common-modules: done
config-flow-test-coverage:
status: todo
comment:
We should have the happy flow as the first test, which can be merged with test_show_form.
The config flow tests are missing adding a duplicate entry test.
config-flow:
status: todo
comment: Limit the scope of the try block in the user step
dependency-transparency: done
docs-actions:
status: exempt
comment: No custom actions are defined.
docs-high-level-description: done
docs-installation-instructions: done
docs-removal-instructions: done
entity-event-setup: done
entity-unique-id: done
has-entity-name: done
runtime-data:
status: todo
comment: No direct need to wrap the coordinator in a dataclass to store in the config entry
test-before-configure: done
test-before-setup: done
unique-config-entry: done

# Silver
action-exceptions:
status: exempt
comment: No custom actions are defined.
config-entry-unloading: done
docs-configuration-parameters:
status: exempt
comment: No options flow
docs-installation-parameters: done
entity-unavailable: done
integration-owner: done
log-when-unavailable: done
parallel-updates: done
reauthentication-flow:
status: exempt
comment: This integration does not require authentication.
test-coverage:
status: todo
comment:
The `test_async_setup_entry` should test the state of the mock config entry, instead of an entity state
The `test_availability` doesn't really do what it says it does, and this is now already tested via the snapshot tests.

# Gold
devices: done
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we actually cache the name in the entry data instead of using the up to date name?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, CONF_NAME was a user-configurable field, with "Home" used as the default value when the user did not provide a custom name.

With the changes introduced in #155762, the integration now always uses the value stored in CONF_NAME as the device name. The device name is no longer derived from live station data at runtime.

This makes CONF_NAME a required piece of persisted configuration data. To maintain backward compatibility - especially for downgrade scenarios where older Home Assistant versions still expect CONF_NAME to be present - we always populate CONF_NAME when creating the config entry.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't really consider downgrading a use case, but this is a nice food for thought

diagnostics: done
discovery-update-info:
status: exempt
comment: This integration is a cloud service and thus does not support discovery.
discovery:
status: exempt
comment: This integration is a cloud service and thus does not support discovery.
docs-data-update: done
docs-examples: done
docs-known-limitations: done
Comment thread
mik-laj marked this conversation as resolved.
docs-supported-devices:
status: exempt
comment: This is an service, which doesn't integrate with any devices.
docs-supported-functions: done
docs-troubleshooting: done
docs-use-cases: done
dynamic-devices:
status: exempt
comment: This integration does not have devices.
entity-category: done
entity-device-class:
status: todo
comment: We can use the CO device class for the carbon monoxide sensor
entity-disabled-by-default: done
entity-translations:
status: todo
comment: We can remove the options state_attributes.
exception-translations: done
icon-translations: done
reconfiguration-flow:
Comment thread
mik-laj marked this conversation as resolved.
status: exempt
comment: Only parameter that could be changed station_id would force a new config entry.
repair-issues: done
stale-devices:
status: exempt
comment: This integration does not have devices.

# Platinum
async-dependency: done
inject-websession: done
strict-typing: done
1 change: 0 additions & 1 deletion script/hassfest/quality_scale.py
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,6 @@ class Rule:
"geofency",
"geonetnz_quakes",
"geonetnz_volcano",
"gios",
"github",
"gitlab_ci",
"gitter",
Expand Down