Skip to content

Moon translate #15498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 5 commits into from
Jul 18, 2018
+22 −10
Merged

Moon translate #15498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2220970
Translate moon
pvizeli Jul 16, 2018
e8ed3a0
Create strings.moon.json
pvizeli Jul 16, 2018
f2282a0
Update moon.py
pvizeli Jul 17, 2018
23c94f7
Update strings.moon.json
pvizeli Jul 17, 2018
7b74635
Update test_moon.py
pvizeli Jul 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions homeassistant/components/sensor/moon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,20 +50,20 @@ def name(self):
def state(self):
"""Return the state of the device."""
if self._state == 0:
return 'New moon'
return 'new_moon'
elif self._state < 7:
return 'Waxing crescent'
return 'waxing_crescent'
elif self._state == 7:
return 'First quarter'
return 'first_quarter'
elif self._state < 14:
return 'Waxing gibbous'
return 'waxing_gibbous'
elif self._state == 14:
return 'Full moon'
return 'full_moon'
elif self._state < 21:
return 'Waning gibbous'
return 'waning_gibbous'
elif self._state == 21:
return 'Last quarter'
return 'Waning crescent'
return 'last_quarter'
return 'waning_crescent'

@property
def icon(self):
Expand Down
12 changes: 12 additions & 0 deletions homeassistant/components/sensor/strings.moon.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"state": {
"new_moon": "New moon",
"waxing_crescent": "Waxing crescent",
"first_quarter": "First quarter",
"waxing_gibbous": "Waxing gibbous",
"full_moon": "Full moon",
"waning_gibbous": "Waning gibbous",
"last_quarter": "Last quarter",
"waning_crescent": "Waning crescent"
}
}
4 changes: 2 additions & 2 deletions tests/components/sensor/test_moon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def test_moon_day1(self, mock_request):
assert setup_component(self.hass, 'sensor', config)

state = self.hass.states.get('sensor.moon_day1')
self.assertEqual(state.state, 'Waxing crescent')
self.assertEqual(state.state, 'waxing_crescent')

@patch('homeassistant.components.sensor.moon.dt_util.utcnow',
return_value=DAY2)
Expand All @@ -53,4 +53,4 @@ def test_moon_day2(self, mock_request):
assert setup_component(self.hass, 'sensor', config)

state = self.hass.states.get('sensor.moon_day2')
self.assertEqual(state.state, 'Waning gibbous')
self.assertEqual(state.state, 'waning_gibbous')