Merged
Conversation
homeassistant
added
cla-signed
platform: sensor.moon
small-pr
ghost
assigned
c727
reviewed
Jul 16, 2018
| """Return the state of the device.""" | ||
| if self._state == 0: | ||
| return 'New moon' | ||
| return 'new moon' |
There was a problem hiding this comment.
although we can use whitespaces in translation file keys, I'm not sure if we want this wild mix of " ", "_". "-" for states
7 tasks
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
* Translate moon * Create strings.moon.json * Update moon.py * Update strings.moon.json * Update test_moon.py
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Translate moon * Create strings.moon.json * Update moon.py * Update strings.moon.json * Update test_moon.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I try to add a translation for moon sensor. I change it like the season sensor. A sensor they return a string should be lowercase. It should be return a number as sensor but it work now like in this way.