Merged
Conversation
ghost
assigned
houndci-bot
reviewed
Jul 11, 2018
| @@ -0,0 +1,111 @@ | |||
| :"""Offer API to configure Home Assistant auth.""" | |||
| from homeassistant.core import callback | |||
| from homeassistant.components import websocket_api | |||
There was a problem hiding this comment.
module level import not at top of file
| @@ -0,0 +1,111 @@ | |||
| :"""Offer API to configure Home Assistant auth.""" | |||
| from homeassistant.core import callback | |||
There was a problem hiding this comment.
module level import not at top of file
| @@ -0,0 +1,111 @@ | |||
| :"""Offer API to configure Home Assistant auth.""" | |||
There was a problem hiding this comment.
missing whitespace after ':'
SyntaxError: invalid syntax
jeradM
reviewed
Jul 12, 2018
homeassistant/scripts/auth.py
Outdated
| data = hass_auth.Data(hass) | ||
| loop.run_until_complete(data.async_load()) | ||
| loop.run_until_complete(args.func(data, args)) | ||
| loop.run_until_complete(hass, args.func(data, args)) |
Member
There was a problem hiding this comment.
The command line seems broken. Should this be loop.run_until_complete(args.func(hass, data, args))?
awarecan
added a commit
to awarecan/home-assistant
that referenced
this pull request
Jul 13, 2018
Cherry pick from home-assistant#15420
houndci-bot
reviewed
Jul 13, 2018
tests/scripts/test_auth.py
Outdated
|
|
||
| await script_auth.validate_login( | ||
| data, Mock(username='invalid-user', password='test-pass')) | ||
| hass, provider, data, Mock(username='invalid-user', password='test-pass')) |
There was a problem hiding this comment.
line too long (82 > 79 characters)
tests/scripts/test_auth.py
Outdated
|
|
||
| await script_auth.validate_login( | ||
| data, Mock(username='test-user', password='invalid-pass')) | ||
| hass, provider, data, Mock(username='test-user', password='invalid-pass')) |
There was a problem hiding this comment.
line too long (82 > 79 characters)
7 tasks
awarecan
pushed a commit
to awarecan/home-assistant
that referenced
this pull request
Jul 16, 2018
* User management * Lint * Fix dict * Reuse data instance * OrderedDict all the way
Merged
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
* User management * Lint * Fix dict * Reuse data instance * OrderedDict all the way
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* User management * Lint * Fix dict * Reuse data instance * OrderedDict all the way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
# We should first merge #15335 (comment)Merged #15443 insteadDescription:
Allow managing users via API. Only owners are allowed to use this API.
Related issue (if applicable): fixes #15194
Example entry for
configuration.yaml(if applicable):https://developers.home-assistant.io/blog/2018/07/02/trying-new-auth.html
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: