Add lock platform to Volvo integration#154168
Conversation
|
👋 Hello, just sharing recently opened discussion to link things together. Glad to see recent actions/buttons and device tracker features. 🎉 |
gjohansson-ST
left a comment
There was a problem hiding this comment.
Codes looks fine but I'm hesitant to make two locks for the same lock
Should this not be one lock and possibly something else to set if it's full lock or reduced? Not sure myself was is the better approach.
|
Thanks for the feedback @gjohansson-ST! In the Volvo app there is one dedicated lock/unlock button. Next to it, there's a select with the following options: Lock, Lock with reduced guard, Unlock trunk. To mimic this approach we could also have on lock entity and then a button that does the "Lock with reduced guard". Also, there is no way to tell afterwards how the car was locked. So the button could be a fit. (Unlock trunk is not possible with the API.) |
Initially I was thinking maybe a |
|
I have removed the "reduced guard" lock from this PR. I'll create a new PR later to add this "reduced guard" as a button. |
Proposed change
Add lock platform to Volvo integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: