Skip to content

Fix credentials lookup#15409

Merged
balloob merged 1 commit intodevfrom
fix-credentials-lookup
Jul 10, 2018
Merged

Fix credentials lookup#15409
balloob merged 1 commit intodevfrom
fix-credentials-lookup

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Jul 10, 2018

Description:

Fix credentials lookup.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner July 10, 2018 18:18
@homeassistant homeassistant added core small-pr PRs with less than 30 lines. labels Jul 10, 2018
@ghost ghost assigned balloob Jul 10, 2018
@ghost ghost added in progress and removed cla-signed labels Jul 10, 2018
awarecan
awarecan approved these changes Jul 10, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@awarecan awarecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balloob balloob merged commit 1f6331c into dev Jul 10, 2018
@ghost ghost removed the in progress label Jul 10, 2018
@balloob balloob deleted the fix-credentials-lookup branch July 10, 2018 18:33
awarecan pushed a commit to awarecan/home-assistant that referenced this pull request Jul 16, 2018
@balloob @awarecan
Fix credentials lookup (home-assistant#15409)
9ef7425
@balloob balloob mentioned this pull request Jul 20, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@awarecan awarecan awarecan approved these changes

Assignees

@balloob balloob

Labels

core small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@balloob @awarecan @homeassistant