Skip to content

Removed unused return from Cloudflare#15402

Merged
fabaff merged 1 commit intohome-assistant:devfrom
ludeeus:patch-1
Jul 10, 2018
Merged

Removed unused return from Cloudflare#15402
fabaff merged 1 commit intohome-assistant:devfrom
ludeeus:patch-1

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Jul 10, 2018

Description:

#15388 (comment)

  • Removed this return based on this comment.

local testing indicates everyrhing works without this.
This is an addition to #15388

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Jul 10, 2018
@ludeeus ludeeus mentioned this pull request Jul 10, 2018
8 tasks
@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes.

@fabaff fabaff merged commit b65d7da into home-assistant:dev Jul 10, 2018
@ghost ghost removed the in progress label Jul 10, 2018
awarecan pushed a commit to awarecan/home-assistant that referenced this pull request Jul 16, 2018
@balloob balloob mentioned this pull request Jul 20, 2018
michaeldavie pushed a commit to michaeldavie/home-assistant that referenced this pull request Jul 31, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants