Skip to content

Upgrade python-melcloud to 0.1.2#153742

Merged
frenck merged 1 commit into
home-assistant:devfrom
Sander0542:chore/update-python-melcloud-v0.1.1
Oct 5, 2025
Merged

Upgrade python-melcloud to 0.1.2#153742
frenck merged 1 commit into
home-assistant:devfrom
Sander0542:chore/update-python-melcloud-v0.1.1

Conversation

@Sander0542
Copy link
Copy Markdown
Contributor

@Sander0542 Sander0542 commented Oct 5, 2025

Breaking change

None

Proposed change

Upgrade python-melcloud to version 0.1.2

https://github.com/erwindouna/python-melcloud/releases/tag/v0.1.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added bugfix cla-signed dependency Pull requests marked as a dependency upgrade Hacktoberfest integration: melcloud small-pr PRs with less than 30 lines. Quality Scale: No score labels Oct 5, 2025
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Oct 5, 2025

Hey there @erwindouna, mind taking a look at this pull request as it has been labeled with an integration (melcloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of melcloud can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign melcloud Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@erwindouna
Copy link
Copy Markdown
Member

The release isn't successfully deployed, yet. Please hold back this upgrade for a bit. I'm working on it. :)

@Sander0542 Sander0542 marked this pull request as draft October 5, 2025 11:04
@Sander0542
Copy link
Copy Markdown
Contributor Author

The release isn't successfully deployed, yet. Please hold back this upgrade for a bit. I'm working on it. :)

Sorry, I saw the new release in GitHub and thought to help with the Home Assistant PR. I am happy to close or update the PR when you have the version ready

@erwindouna
Copy link
Copy Markdown
Member

Should be released. The library contained an older version of Poetry core which was not compatible with the pypi release pipeline anymore.
Also, please do verify you ran the tests locally, before putting this PR on ready. :)

@Sander0542 Sander0542 force-pushed the chore/update-python-melcloud-v0.1.1 branch from a577c80 to ad2392f Compare October 5, 2025 13:36
@Sander0542 Sander0542 changed the title Upgrade python-melcloud to 0.1.1 Upgrade python-melcloud to 0.1.2 Oct 5, 2025
@Sander0542 Sander0542 marked this pull request as ready for review October 5, 2025 13:43
@Sander0542
Copy link
Copy Markdown
Contributor Author

@erwindouna I just tested this branch using a local setup. It worked right away, I could see the changes in the MELCloud app too, and the ATA device also showed changes.

Could you review the PR, please?

Copy link
Copy Markdown
Member

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline look good so far. Thanks for contributing and improving the library, @Sander0542 ! :)

@Sander0542
Copy link
Copy Markdown
Contributor Author

Looks like the pipeline failed on the playstation_network integration

@erwindouna
Copy link
Copy Markdown
Member

Try a rebase. Otherwise the failures are not related to this PR.

@Sander0542
Copy link
Copy Markdown
Contributor Author

Looking at the 10 new commits, there were no changes to the playstation_network integration, so hopefully the rerun of the tests fixes it.

@Sander0542 Sander0542 force-pushed the chore/update-python-melcloud-v0.1.1 branch from 13b08f4 to 0781283 Compare October 5, 2025 14:07
@Sander0542
Copy link
Copy Markdown
Contributor Author

The pipeline succeeded now :)

@frenck frenck added this to the 2025.10.2 milestone Oct 5, 2025
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Sander0542 👍

../Frenck

@frenck frenck merged commit fed8f13 into home-assistant:dev Oct 5, 2025
48 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants