Skip to content

Add outside temperature sensor to MELCloud Air-to-Air devices#150722

Merged
emontnemery merged 1 commit into
home-assistant:devfrom
Sander0542:feature/ata-device-outside-temperature
Nov 3, 2025
Merged

Add outside temperature sensor to MELCloud Air-to-Air devices#150722
emontnemery merged 1 commit into
home-assistant:devfrom
Sander0542:feature/ata-device-outside-temperature

Conversation

@Sander0542
Copy link
Copy Markdown
Contributor

@Sander0542 Sander0542 commented Aug 15, 2025

Proposed change

This PR add the outside temperature sensor to the ATA (Air-toAir, Air conditioner) devices of the MELCloud integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added cla-signed dependency Pull requests marked as a dependency upgrade integration: melcloud new-feature small-pr PRs with less than 30 lines. labels Aug 15, 2025
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @erwindouna, mind taking a look at this pull request as it has been labeled with an integration (melcloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of melcloud can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign melcloud Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@Sander0542 Sander0542 changed the title feature: Add outside temperature sensor to ATA sensors Add outside temperature sensor to MELCloud Air-to-Air devices Aug 15, 2025
@Sander0542 Sander0542 force-pushed the feature/ata-device-outside-temperature branch from 3591479 to f15bc7d Compare October 5, 2025 18:21
@emontnemery
Copy link
Copy Markdown
Contributor

@Sander0542 What is this PR waiting for?

@Sander0542
Copy link
Copy Markdown
Contributor Author

I completely forgot about this PR. It is ready now since the library has been updated

@Sander0542 Sander0542 force-pushed the feature/ata-device-outside-temperature branch from f15bc7d to 5e31a68 Compare October 31, 2025 16:10
@Sander0542 Sander0542 marked this pull request as ready for review October 31, 2025 16:10
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Sander0542 👍

@emontnemery emontnemery merged commit ec25ead into home-assistant:dev Nov 3, 2025
36 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed dependency Pull requests marked as a dependency upgrade integration: melcloud new-feature Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants