Conversation
ghost
assigned
houndci-bot
reviewed
Jul 8, 2018
| }, auth=CLIENT_AUTH) | ||
| assert resp.status == 200 | ||
| }) | ||
| assert resp.status == 200, step |
awarecan
reviewed
Jul 8, 2018
| if parts.password is not None: | ||
| raise ValueError('Client ID cannot contain password') | ||
|
|
||
| # MAY contain a port |
Contributor
There was a problem hiding this comment.
EDIT: I was wrong. There is no issue.
It has two paragraph in spec very close, 3.1 User Profile URL and 3.2 Client Identifier, the only different between these two are User Profile URL do not allow port and ip address, Client Identifier allow port and 127.0.0.1
I confused those two.
houndci-bot
reviewed
Jul 9, 2018
| @@ -0,0 +1,98 @@ | |||
| """Helpers to resolve client ID/secret.""" | |||
| from ipaddress import ip_address | |||
There was a problem hiding this comment.
'ipaddress.ip_address' imported but unused
Contributor
|
LGTM |
awarecan
pushed a commit
to awarecan/home-assistant
that referenced
this pull request
Jul 16, 2018
* Use IndieAuth for client ID * Lint * Lint & Fix tests * Allow local IP addresses * Update comment
Merged
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
* Use IndieAuth for client ID * Lint * Lint & Fix tests * Allow local IP addresses * Update comment
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Use IndieAuth for client ID * Lint * Lint & Fix tests * Allow local IP addresses * Update comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Implements the IndieAuth approach to clients.
Related issue (if applicable): home-assistant/architecture#44
Example entry for
configuration.yaml(if applicable):See https://developers.home-assistant.io/blog/2018/07/02/trying-new-auth.html
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: