Skip to content

Add python 3.8-dev to travis and tox#15347

Merged
balloob merged 4 commits intohome-assistant:devfrom
andrey-git:py38
Jul 13, 2018
Merged

Add python 3.8-dev to travis and tox#15347
balloob merged 4 commits intohome-assistant:devfrom
andrey-git:py38

Conversation

@andrey-git
Copy link
Copy Markdown
Contributor

@andrey-git andrey-git commented Jul 7, 2018

Description:

Add python 3.8-dev to travis and tox

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@homeassistant homeassistant added cla-signed small-pr PRs with less than 30 lines. labels Jul 7, 2018
@ghost ghost assigned andrey-git Jul 7, 2018
@ghost ghost added the in progress label Jul 7, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Jul 8, 2018

I am not a really big fan. This adds 21 minutes to each and every build of Home Assistant.

@andrey-git
Copy link
Copy Markdown
Contributor Author

13:38 on second run.

@andrey-git
Copy link
Copy Markdown
Contributor Author

Third run 9:48 on par with other python versions

@balloob
Copy link
Copy Markdown
Member

balloob commented Jul 8, 2018

So should we have allow failure true? Because I remember having this at some point for 3.7 and all tests started failing because they accidentally broke something.

@andrey-git
Copy link
Copy Markdown
Contributor Author

I think we should try without, and add it if Travis breaks and there is no easy fix.

@balloob
Copy link
Copy Markdown
Member

balloob commented Jul 9, 2018

The problem that once it breaks, the open PRs won't have allow failure true on it. Also usually breaking changes are not introduced in a PR but something existing breaks

@balloob
Copy link
Copy Markdown
Member

balloob commented Jul 9, 2018

Now that we allow failures, we are adding 25% time to every build with no real added value of seeing if things are going to break.

I wish that we could run a 3.8-dev build once a day, not on every build. Especially when I am dong a lot of code reviews, waiting for builds to finish can be a limiting factor (I sometimes make minor edits myself to get a PR through).

@andrey-git
Copy link
Copy Markdown
Contributor Author

But those run in parallel (on Travis) and since 3.8 is allowed to fail Travis will Mark the build green without waiting for it.

@balloob
Copy link
Copy Markdown
Member

balloob commented Jul 9, 2018

Travis will only assign X workers (depends on time/how busy it is) to Home Assistant. So if there is more work to be done, builds will wait for other HA builds.

@andrey-git
Copy link
Copy Markdown
Contributor Author

Now it will run only on pushes to dev and not on each PR change.
WDYT?

(We could make it run on pushes to master to make it really rare)

@balloob
Copy link
Copy Markdown
Member

balloob commented Jul 13, 2018

Perfect.

@balloob balloob merged commit 23f1b49 into home-assistant:dev Jul 13, 2018
@ghost ghost removed the in progress label Jul 13, 2018
@andrey-git andrey-git deleted the py38 branch July 13, 2018 10:22
awarecan pushed a commit to awarecan/home-assistant that referenced this pull request Jul 16, 2018
* Add Python 3.8-dev tox tests.

* Allow failures on 3.8-dev

* Allow failures on 3.8-dev take2

* Only run on pushes to dev
@balloob balloob mentioned this pull request Jul 20, 2018
michaeldavie pushed a commit to michaeldavie/home-assistant that referenced this pull request Jul 31, 2018
* Add Python 3.8-dev tox tests.

* Allow failures on 3.8-dev

* Allow failures on 3.8-dev take2

* Only run on pushes to dev
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
* Add Python 3.8-dev tox tests.

* Allow failures on 3.8-dev

* Allow failures on 3.8-dev take2

* Only run on pushes to dev
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed Ready for review small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants