Add HomematicIP Cloud light power consumption and energie attributes#15343
Merged
MartinHjelmare merged 3 commits intohome-assistant:devfrom Jul 9, 2018
worm-ee:update-homematicip_cloud-lights_power_consumption
Merged
Add HomematicIP Cloud light power consumption and energie attributes#15343MartinHjelmare merged 3 commits intohome-assistant:devfrom worm-ee:update-homematicip_cloud-lights_power_consumption
MartinHjelmare merged 3 commits intohome-assistant:devfrom
worm-ee:update-homematicip_cloud-lights_power_consumption
Conversation
homeassistant
added
cla-signed
platform: light.homematicip_cloud
small-pr
houndci-bot
reviewed
Jul 7, 2018
| attr = super().device_state_attributes | ||
| if self._device.currentPowerConsumption > 0.05: | ||
| attr.update({ | ||
| ATTR_POWER_CONSUMPTION: round(self._device.currentPowerConsumption, 2) |
worm-ee
changed the title
Member
|
Please add a paragraph in the description describing the breaking change, ie the change in the state attributes. |
Contributor
Author
|
Hi Martin, thanks for your review. It’s not breaking - it’s new added. |
| """MomematicIP measuring light device.""" | ||
|
|
||
| @property | ||
| def current_power_w(self): |
Member
There was a problem hiding this comment.
Since these properties are removed, this is a breaking change.
Contributor
Author
|
Hi Martin, when I implemented the light platform I was not aware that those properties are not implemented like in the switch platform, now I have moved them to the state attributes. So I still think this not a breaking change, but you can still convince me :-) |
Member
|
Sorry, you're right. I was thinking this was the switch. 🤦♂️ |
MartinHjelmare
approved these changes
Jul 9, 2018
awarecan
pushed a commit
to awarecan/home-assistant
that referenced
this pull request
Jul 16, 2018
…ome-assistant#15343) * Add power consumption and energie attributes * Fix lint * Change attribute name and include kwh
Merged
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
…ome-assistant#15343) * Add power consumption and energie attributes * Fix lint * Change attribute name and include kwh
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
…ome-assistant#15343) * Add power consumption and energie attributes * Fix lint * Change attribute name and include kwh
ghost
added
integration: homematicip_cloud
and removed
platform: light.homematicip_cloud
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Checklist:
tox. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.