fix camera.push API overwrite#15334
Merged
balloob merged 4 commits intohome-assistant:devfrom Jul 9, 2018
Merged
Conversation
homeassistant
added
platform: camera.push
small-pr
ghost
assigned
balloob
requested changes
Jul 8, 2018
| config[CONF_TIMEOUT])] | ||
|
|
||
| hass.http.register_view(CameraPushReceiver(cameras, | ||
| component = hass.data.get(DOMAIN) |
Member
There was a problem hiding this comment.
You're not allowed to do this. You have to keep track of your own entities yourself. This is an internal thing of the camera component.
houndci-bot
reviewed
Jul 8, 2018
| _LOGGER.error("Unknown push camera %s", entity_id) | ||
| return self.json_message('Unknown Push Camera', | ||
| _camera = self._cameras.get(entity_id) | ||
|
|
balloob
approved these changes
Jul 9, 2018
awarecan
pushed a commit
to awarecan/home-assistant
that referenced
this pull request
Jul 16, 2018
* fix camera.push API overwrite * dont search in the component dictionary, but in hour own * remove error message * hound
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When more than one camera exists, the CameraPushReceiver would only have information on a single camera.
This PR fixes this issue.
Related issue (if applicable): fixes #15151
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: