Fix confused brightness of xiaomi_aqara gateway light#15314
Merged
Danielhiversen merged 1 commit intohome-assistant:devfrom Jul 10, 2018
Merged
Fix confused brightness of xiaomi_aqara gateway light#15314Danielhiversen merged 1 commit intohome-assistant:devfrom
Danielhiversen merged 1 commit intohome-assistant:devfrom
Conversation
homeassistant
added
cla-signed
platform: light.xiaomi_aqara
small-pr
ghost
assigned
|
|
||
| @property | ||
| def brightness(self): | ||
| """Return the brightness of this light between 0..255.""" |
Member
There was a problem hiding this comment.
Change the doc string too
Contributor
Author
There was a problem hiding this comment.
Hmm, the property self.brightness is actually 0..255.
awarecan
pushed a commit
to awarecan/home-assistant
that referenced
this pull request
Jul 16, 2018
Merged
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
There was a mixup of scales 0-100 (Xiaomi) and 0-255 (Home Assistant). This caused the brightness to change when setting a new
hs_color.Now
self._brightnessis always 0-100.Checklist:
tox.If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.