Make LimitlessLED color/temperature attributes mutually exclusive#15298
Merged
amelchio merged 1 commit intohome-assistant:devfrom Jul 12, 2018
Merged
Make LimitlessLED color/temperature attributes mutually exclusive#15298amelchio merged 1 commit intohome-assistant:devfrom
amelchio merged 1 commit intohome-assistant:devfrom
Conversation
homeassistant
added
cla-signed
platform: light.limitlessled
small-pr
ghost
assigned
amelchio
force-pushed
the
limitlessled-color-or-white
branch
from
e37b290 to
acb83ef
Compare
Contributor
Author
|
I think objections would have been raised by now if this was way off so I will go ahead and merge it. |
awarecan
pushed a commit
to awarecan/home-assistant
that referenced
this pull request
Jul 16, 2018
Merged
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Since a light cannot be white and colored at the same time, this PR changes LimitlessLED to only report one of the
hs_color/color_tempattributes. The temperature is used when the saturation is zero.While at it, this PR also adds the effect feature bit for white lights. I missed that in #12567.
Breaking change: LimitlessLED will no longer report
hs_color/rgb_colorandcolor_tempsimultaneously.Checklist:
tox.If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.