Skip to content

Add system generated users#15291

Merged
balloob merged 2 commits into
devfrom
system-user
Jul 4, 2018
Merged

Add system generated users#15291
balloob merged 2 commits into
devfrom
system-user

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Jul 3, 2018

Description:

Cleaning up the Auth Store. Making a clear distinction: AuthManager has business logic, AuthStore just stores and retrieves objects.

Added system generated users. This will be so that Hass.io can have a user to allow add-ons to connect. Eventually we might want to clean it up.

Related issue (if applicable): #15220

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@awarecan
Copy link
Copy Markdown
Contributor

awarecan commented Jul 4, 2018

LGTM

Did not see the usage of async_create_system_user. I am assuming it will be part of hass.io deliverable.

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Jul 4, 2018

Yeah, it got all a bit too big!

@balloob balloob merged commit cb129bd into dev Jul 4, 2018
@ghost ghost removed the in progress label Jul 4, 2018
@balloob balloob deleted the system-user branch July 4, 2018 15:50
awarecan pushed a commit to awarecan/home-assistant that referenced this pull request Jul 16, 2018
* Add system generated users

* Fix typing
@balloob balloob mentioned this pull request Jul 20, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
* Add system generated users

* Fix typing
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants