Skip to content

Add support for new fixer API (fixes #14911)#15279

Merged
fabaff merged 1 commit into
devfrom
upgrade-fixerio
Jul 3, 2018
Merged

Add support for new fixer API (fixes #14911)#15279
fabaff merged 1 commit into
devfrom
upgrade-fixerio

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented Jul 3, 2018

Description:

Fixer.io updated their API and now it's required to have an API key. Support for SSL/TLS is only available for paying customers.

Related issue (if applicable): fixes #14911

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5654

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: fixer
    api_key: !secret fixer_api
    target: CHF

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@ghost ghost assigned fabaff Jul 3, 2018
@ghost ghost added the in progress label Jul 3, 2018
@fabaff
Copy link
Copy Markdown
Member Author

fabaff commented Jul 3, 2018

Breaking change:
Fixer.io now requires you to have an API key to use their service. Please check the fixer sensor documentation for an update of your configuration as base is no longer supported but api_key required.

@MartinHjelmare MartinHjelmare changed the title Add support for new API (fixes #14911) Add support for new fixer API (fixes #14911) Jul 3, 2018
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Copy Markdown
Member

Maybe also mention removal of base key in options in the breaking change notes.

@fabaff
Copy link
Copy Markdown
Member Author

fabaff commented Jul 3, 2018

Note updated.

@fabaff fabaff merged commit 232f56d into dev Jul 3, 2018
@ghost ghost removed the in progress label Jul 3, 2018
@fabaff fabaff deleted the upgrade-fixerio branch July 3, 2018 10:31
@metbril
Copy link
Copy Markdown

metbril commented Jul 5, 2018

The API docs still mention ‘base’ as optional.

https://fixer.io/documentation#latestrates

Why has this been removed from the component?

Also the scan interval is 1 day by default. The free API allows 1 call per hour. The scan interval can be increased if we make 1 call for all rates at once.

This would require changes to the configuration however,

sensor:
  - platform: fixer
    ## https://www.home-assistant.io/components/sensor.fixer/
    target: 
      - USD
      - CHF
    base: EUR
    name: Exchange Rate

Where there is only one 'base' for all rates and 'name' will become a prefix for any rate. Like 'exchange_rate_usd' and 'exchange_rate_chf'. Name could have a seensible default or be empty (no prefix).

awarecan pushed a commit to awarecan/home-assistant that referenced this pull request Jul 16, 2018
@balloob balloob mentioned this pull request Jul 20, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixer.io doesn't work anymore

4 participants