expose climate current temperature in prometeus metrics#15232
Merged
balloob merged 4 commits intoJul 2, 2018
Conversation
Contributor
homeassistant
added
cla-needed
integration: prometheus
core
small-pr
ghost
added
the
balloob
requested changes
Jul 1, 2018
| # Temperature attribute | ||
| ATTR_TEMPERATURE = 'temperature' | ||
|
|
||
| # Current Temperature attribute |
Member
There was a problem hiding this comment.
Please don't add this to main const but import it from climate component.
Contributor
Author
There was a problem hiding this comment.
I've removed this from the main constants and I'm now importing it from the climate component. Thanks.
balloob
approved these changes
Jul 2, 2018
Contributor
Author
|
Thank you! |
awarecan
pushed a commit
to awarecan/home-assistant
that referenced
this pull request
Jul 16, 2018
…nt#15232) * expose climate current temperature in prometeus metrics * import ATTR_CURRENT_TEMPERATURE from climate instead of const * remove duplicated ATTR_CURRENT_TEMPERATURE from const * fix ATTR_CURRENT_TEMPERATURE import
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Exposes current temperature in climate components to Prometheus exporter.
Before it just exposed the desired temperature.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: