Add support for Tahoma smoke sensor, light switch and two awning io components by fucm · Pull Request #14931 · home-assistant/core

fucm · 2018-06-11T20:30:09Z

Description:

Add support for 4 Tahoma devices:

io:VerticalExteriorAwningIOComponent: a new cover type
io:HorizontalAwningIOComponent: a new cover type (just added, because I have them not available for testing - they should behave like the vertical ones)
io:OnOffLightIOComponent: light switch
rtds:RTDSSmokeSensor: smoke sensor

Additional improvements:

added all available state attributes, like battery warning, rssi level, memorised position, lock timer/level/originator.
added special icon for the awnings, if they are locked by wind or something else.
added special icon for the smoke sensor, if fire is detected or the battery is low.
increase sensor update time from 10s to 120s

Related issue (if applicable): fixes #13965

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5590

Example entry for `configuration.yaml` (if applicable):

nothing

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

No new dependencies.
New file already covered by components/*/tahoma.py (.coveragerc).

If the code does not interact with devices:

N/A (interacts with devices).

- 'io:VerticalExteriorAwningIOComponent': 'cover' - 'io:HorizontalAwningIOComponent': 'cover' - 'io:OnOffLightIOComponent': 'switch' - 'rtds:RTDSSmokeSensor': 'smoke'

- all: provide available state attributes - binary_sensor: smoke sensor can show battery warning icon - sensor: increase sensor update time from 10s to 120s

…to tahoma-io

homeassistant · 2018-06-11T20:30:12Z

Hi @fucm,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

… set ETA as well (home-assistant#14901)

More test cases to cover retry logic added in 58a1c38

…me-assistant#14823) * start arlo refactoring * Refactored Arlo Hub to avoid uncessary and duplicated GETs to Arlo API * Refactored Arlo camera component to avoid duplicate queries * Added debug and error messages when video is not found * Transformed Arlo Control Panel to Sync * Makes linter happy * Uses total_seconds() for scan_interval * Added callback and fixed scan_interval issue * Disable multiple tries and supported custom modes set in Arlo * Bump PyArlo version to 0.1.4 * Makes lint happy * Removed ArloHub object and added some tweaks * Fixed hub_refresh method * Makes lint happy * Ajusted async syntax and added callbacks decorators * Bump PyArlo version to 0.1.6 to include some enhacements * Refined code

* initial commit for kiwi door locks bugfixes improved attribute display flake8 more style adjustments * added session handling flake8 * added requirements_all reordered imports and flake8 attempt to pelase a very picky linter also pleasing pylint now :) * re-try the build * added kiwi.py to .coveragerc * reorganized datetime handling and attribute naming * created pypi package for door lock library * updated requirements_all.txt * code review changes * added async lock state reset for locking state * refactored lat/lon attribute updates * initial locked state changed from undefined to locked * refactored is_locked property check * handling authentication exception in setup_platform * added more check in setup_platform * code review changes: return type in setup_platform * fixed logging issue * event handling in main thread * updated kiwiki-client to version 0.1.1 * renamed alias e to exc

Current uuid is ok when using only 1 snapserver New uuid is needed when using multiple snapserver Because the client can connect to more snapservers and then uuid based on client MAC is not enough

- 'io:VerticalExteriorAwningIOComponent': 'cover' - 'io:HorizontalAwningIOComponent': 'cover' - 'io:OnOffLightIOComponent': 'switch' - 'rtds:RTDSSmokeSensor': 'smoke'

- all: provide available state attributes - binary_sensor: smoke sensor can show battery warning icon - sensor: increase sensor update time from 10s to 120s

balloob · 2018-06-15T19:08:56Z

-        except KeyError:
-            return None
+            if self._position <= 5:
+                self._position = 0


Why is this?

Actually, I don't know. It was there since the beginning (#10652). So, I kept the code.

balloob · 2018-06-15T19:09:34Z

        return None

+    @property
+    def state_attributes(self):


Do not override state_attributes. Devices can override device_state_attributes

Ok, I'll update it.

balloob · 2018-06-15T19:10:13Z


 _LOGGER = logging.getLogger(__name__)

+ATTR_CLOSURE = 'closure'


Please limit PRs to 1 feature per PR next time. So changes to binary sensor and cover: 2 prs.

I will do so in the future. Sorry.

balloob · 2018-06-15T19:10:39Z

+            attr[ATTR_STATUS] = self.tahoma_device.active_states[
+                'core:StatusState']
+        if self._lock_timer is not None:
+            attr[ATTR_LOCK_TIMER] = self._lock_timer


We should store any times in the state machine. Only time stamps are allowed.

I read the docs about the states again and I don't understand, why the lock timer should go into the state machine. It's an attribute of the device for how long it is locked (before it can be used again, e.g. open cover after wind has been detected). It relates directly to lock_level and lock_originator. Could you please point me to an example or the appropriate documentation?

You can store timestamps, so store the exact time when it can be used. Don't store relative times that change on every update.

balloob · 2018-06-15T19:20:22Z

+        return bool(self._state == STATE_ON)
+
+    @property
+    def state_attributes(self):


device_state_attributes

balloob · 2018-06-15T19:20:36Z

+                self.tahoma_device.active_states['core:StatusState']
+        if 'core:PriorityLockTimerState' in self.tahoma_device.active_states:
+            attr[ATTR_LOCK_TIMER] = \
+                self.tahoma_device.active_states['core:PriorityLockTimerState']


Is this the same info as the cover?

Yes, it is the same type of info, but from the switch. Actually I do not know, for what the PriorityLockTimerState is used in case of a switch. For example a cover is blocked by a wind sensor for a certain time, in case of strong wind.

…rm code

…to tahoma-io

fucm · 2018-06-27T18:59:01Z

@balloob is anything open from your review? I don't plan any other changes.

balloob · 2018-07-02T19:29:15Z

It seems like you have some commits in this branch that are not yours, please clean it up.

fucm · 2018-07-02T20:27:32Z

I do not understand where those commits are coming from! My branch looks clean, but the pull request contains the additional commits, which seem to be from other pull requests. Any hint what I could do now? How can I clean it up?

balloob · 2018-07-10T10:08:59Z

https://xkcd.com/1597/

fucm · 2018-07-13T08:24:11Z

I will create smaller pull requests for each component. Closing this pull request.

fucm added 6 commits May 24, 2018 22:35

Add support for 2 cover types, a smoke detector and a light switch:

8e3ffe1

- 'io:VerticalExteriorAwningIOComponent': 'cover' - 'io:HorizontalAwningIOComponent': 'cover' - 'io:OnOffLightIOComponent': 'switch' - 'rtds:RTDSSmokeSensor': 'smoke'

Add available state_attributes to all Tahoma devices

0bedc4a

Add support for 2 cover types, a smoke detector and a light switch:

6b86684

- 'io:VerticalExteriorAwningIOComponent': 'cover' - 'io:HorizontalAwningIOComponent': 'cover' - 'io:OnOffLightIOComponent': 'switch' - 'rtds:RTDSSmokeSensor': 'smoke'

Add available state_attributes to all Tahoma devices

a5044e8

Update Tahoma components to:

7c3bc1f

- all: provide available state attributes - binary_sensor: smoke sensor can show battery warning icon - sensor: increase sensor update time from 10s to 120s

Merge branch 'tahoma-io' of https://github.com/fucm/home-assistant in…

e02c0b9

…to tahoma-io

homeassistant added integration: tahoma new-platform labels Jun 11, 2018

homeassistant added platform: cover.tahoma cla-needed labels Jun 11, 2018

ghost added the in progress label Jun 11, 2018

awarecan and others added 3 commits June 12, 2018 07:28

Upgrade python-nest, add security_state sensor, nest.set_mode service…

30111ea

… set ETA as well (home-assistant#14901)

Add more test cases for samsungtv (home-assistant#14900)

be4776d

More test cases to cover retry logic added in 58a1c38

homeassistant added cla-signed and removed cla-needed labels Jun 12, 2018

awarecan and others added 6 commits June 12, 2018 09:32

Use cv.time_period instead of cv.time_period_str (home-assistant#14938)

c18033b

Fix snapcast uuid to be more unique (home-assistant#14925)

89d008d

Current uuid is ok when using only 1 snapserver New uuid is needed when using multiple snapserver Because the client can connect to more snapservers and then uuid based on client MAC is not enough

Add support for 2 cover types, a smoke detector and a light switch:

d65bc00

- 'io:VerticalExteriorAwningIOComponent': 'cover' - 'io:HorizontalAwningIOComponent': 'cover' - 'io:OnOffLightIOComponent': 'switch' - 'rtds:RTDSSmokeSensor': 'smoke'

Add available state_attributes to all Tahoma devices

bb3f0b7

Update Tahoma components to:

2231a58

- all: provide available state attributes - binary_sensor: smoke sensor can show battery warning icon - sensor: increase sensor update time from 10s to 120s

balloob reviewed Jun 15, 2018

View reviewed changes

fucm added 2 commits June 16, 2018 22:58

Use device_state_attributes instead of state_attributes in the platfo…

24d7ece

…rm code

Merge branch 'tahoma-io' of https://github.com/fucm/home-assistant in…

9b8346d

…to tahoma-io

homeassistant added the cla-signed label Jun 16, 2018

fucm mentioned this pull request Jun 24, 2018

Add Tahoma binary_sensor docu home-assistant/home-assistant.io#5590

Merged

2 tasks

fucm closed this Jul 13, 2018

ghost removed the in progress label Jul 13, 2018

home-assistant locked and limited conversation to collaborators Dec 10, 2018

ghost removed platform: binary_sensor.tahoma labels Mar 21, 2019


		_LOGGER = logging.getLogger(__name__)

		ATTR_CLOSURE = 'closure'

Uh oh!

Conversation

fucm commented Jun 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

homeassistant commented Jun 11, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fucm commented Jun 27, 2018

Uh oh!

balloob commented Jul 2, 2018

Uh oh!

fucm commented Jul 2, 2018

Uh oh!

balloob commented Jul 10, 2018

Uh oh!

fucm commented Jul 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

fucm commented Jun 11, 2018 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):