Skip to content

Use cv.time_period instead of cv.time_period_str#14938

Merged
syssi merged 1 commit intohome-assistant:devfrom
awarecan:fix-nest-eta-service-param
Jun 12, 2018
Merged

Use cv.time_period instead of cv.time_period_str#14938
syssi merged 1 commit intohome-assistant:devfrom
awarecan:fix-nest-eta-service-param

Conversation

@awarecan
Copy link
Copy Markdown
Contributor

Description:

Follow up fix for the code review comment leave after merge of #14901

@syssi please review

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@syssi
Copy link
Copy Markdown
Member

syssi commented Jun 12, 2018

You are quick! Thanks a lot.

@syssi syssi closed this Jun 12, 2018
@ghost ghost removed the in progress label Jun 12, 2018
@syssi syssi reopened this Jun 12, 2018
@ghost ghost assigned syssi Jun 12, 2018
@ghost ghost added the in progress label Jun 12, 2018
@syssi
Copy link
Copy Markdown
Member

syssi commented Jun 12, 2018

Sorry. I'm asleep. I will care about a merge.

@syssi syssi merged commit c18033b into home-assistant:dev Jun 12, 2018
@ghost ghost removed the in progress label Jun 12, 2018
@awarecan awarecan deleted the fix-nest-eta-service-param branch June 19, 2018 01:55
@balloob balloob mentioned this pull request Jun 22, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants