upgrade-mypy#14904
Merged
balloob merged 7 commits intohome-assistant:devfrom Jul 13, 2018
scop:upgrade-mypy
Merged
Conversation
ghost
added
houndci-bot
reviewed
Jun 10, 2018
homeassistant/loader.py
Outdated
|
|
||
|
|
||
| def set_component(hass, comp_name: str, component: ModuleType) -> None: | ||
| def set_component(hass, comp_name: str, component: Optional[ModuleType]) -> None: |
There was a problem hiding this comment.
line too long (81 > 79 characters)
scop
requested review from
Danielhiversen,
Kane610,
amelchio,
andrey-git,
bachya,
cdce8p,
dgomes,
emlove,
kellerza,
rytilahti and
syssi
as code owners
Contributor
|
If you sync to head it should be possible to upgrade mypy without any code changes. |
houndci-bot
reviewed
Jul 13, 2018
homeassistant/loader.py
Outdated
| Components can be accessed via hass.components.switch from your code. | ||
| If you want to retrieve a platform that is part of a component, you should | ||
| call get_component(hass, 'switch.your_platform'). In both cases the config | ||
| call get_component(hass, 'switch.your_platform'). In both cases the config>>>>>>> dev>>>>>>> dev |
There was a problem hiding this comment.
line too long (96 > 79 characters)
awarecan
pushed a commit
to awarecan/home-assistant
that referenced
this pull request
Jul 16, 2018
* Upgrade mypy to 0.600 * Upgrade mypy to 0.610 * Typing improvements * remove unneeded or * remove merge artifact * Update loader.py
Merged
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
* Upgrade mypy to 0.600 * Upgrade mypy to 0.610 * Typing improvements * remove unneeded or * remove merge artifact * Update loader.py
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Upgrade mypy to 0.600 * Upgrade mypy to 0.610 * Typing improvements * remove unneeded or * remove merge artifact * Update loader.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Some further work to the upgrade-mypy branch, still some failures left.