-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
Add Manual Charge Switch for Installers for Kostal Plenticore #146932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Manual Charge Switch for Installers for Kostal Plenticore #146932
Conversation
|
Hey there @stegm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the requirement for #HSFDPMUW?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Only that the hashtag needs to be in a title of a merged pr on a repo thats at least 5 years old. It doesn't have to be in the squashed commit afaik |
We discussed this topic internally and decided that we don't want arbitrary data/hashtags in the PR title or commit message as it's unrelated to HA, and nobody outside your university module will understand it. |
|
Alright, thanks for letting me know |
joostlek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ruff is failing, can you take a look?
|
fixed |
|
I think it would be nice if we can update the integration a bit and add things like a shared base entity and migrate it to |
|
In any case, Thanks! |
Proposed change
The changes add a Manual Charge Switch which is available when having access via Installer Login. This is based on #133773.
It allows users to set a battery to force charge regardless of PV generation.
I have opted to not create the switch when installer login is not active, because the state of that setting is not changing when not having an installer login.
This pr was created as part of a uni module, hence the #HSFDPMUW hashtag. It would be great if it would stay in the title.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: