Skip to content

Conversation

@Schlauer-Hax
Copy link
Contributor

@Schlauer-Hax Schlauer-Hax commented Jun 16, 2025

Proposed change

The changes add a Manual Charge Switch which is available when having access via Installer Login. This is based on #133773.
It allows users to set a battery to force charge regardless of PV generation.
I have opted to not create the switch when installer login is not active, because the state of that setting is not changing when not having an installer login.

This pr was created as part of a uni module, hence the #HSFDPMUW hashtag. It would be great if it would stay in the title.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @stegm, mind taking a look at this pull request as it has been labeled with an integration (kostal_plenticore) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of kostal_plenticore can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign kostal_plenticore Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the requirement for #HSFDPMUW?

@home-assistant home-assistant bot marked this pull request as draft June 16, 2025 12:22
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Schlauer-Hax
Copy link
Contributor Author

Schlauer-Hax commented Jun 16, 2025

What's the requirement for #HSFDPMUW?

Only that the hashtag needs to be in a title of a merged pr on a repo thats at least 5 years old. It doesn't have to be in the squashed commit afaik

@Schlauer-Hax Schlauer-Hax marked this pull request as ready for review June 16, 2025 13:20
@home-assistant home-assistant bot requested a review from joostlek June 16, 2025 13:20
@edenhaus
Copy link
Member

Only that the hashtag needs to be in a title of a merged pr on a repo thats at least 5 years old. It doesn't have to be in the squashed commit afaik

We discussed this topic internally and decided that we don't want arbitrary data/hashtags in the PR title or commit message as it's unrelated to HA, and nobody outside your university module will understand it.
You can have the hashtag in the PR description if you describe that it's needed for the university module (the docs PR is missing this)

@edenhaus edenhaus changed the title Add Manual Charge Switch for Installers #HSFDPMUW Add Manual Charge Switch for Installers Jun 16, 2025
@edenhaus edenhaus changed the title Add Manual Charge Switch for Installers Add Manual Charge Switch for Installers for Kostal Plenticore Jun 16, 2025
@Schlauer-Hax
Copy link
Contributor Author

Alright, thanks for letting me know

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruff is failing, can you take a look?

@home-assistant home-assistant bot marked this pull request as draft June 26, 2025 15:11
@Schlauer-Hax
Copy link
Contributor Author

fixed

@Schlauer-Hax Schlauer-Hax marked this pull request as ready for review June 26, 2025 15:25
@home-assistant home-assistant bot requested a review from joostlek June 26, 2025 15:25
@joostlek joostlek merged commit bf88fcd into home-assistant:dev Jun 26, 2025
33 of 34 checks passed
@joostlek
Copy link
Member

I think it would be nice if we can update the integration a bit and add things like a shared base entity and migrate it to has_entity_name = True. This way we can add translations and make the integration more accessible :D

@joostlek
Copy link
Member

In any case, Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants