-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
Add Kostal plenticore Installer login support #133773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @stegm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
stegm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I have no installer auth, I cannot test it, but code is fine.
joostlek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config flow should be 100% unit tested, so make sure you add tests for the service_code
Service code is already integrated in the existing config flow test, see: line 37 in config_flow.py |
|
But we don't have a test where we do the flow with a service_code |
|
It would also be nice to have a reconfigure flow so existing users can also add it. Can the service code change? |
|
The service code shouldn't change. A service_code change is possible if the user wants to use an other installer account. |
|
I have just added the config flow |
joostlek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also have tests for the reconfigure flow
joostlek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! :)
Proposed change
This change makes it possible to use a installer login with kostal plenticore. It enables access to more settings that are not available from the normal login. The change also adds the ManualCharge Switch which activates Service Charging. This Switch can only be set when the installer login is active.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: