Skip to content

Add python 3.7 to travis and tox#14523

Merged
balloob merged 14 commits intohome-assistant:devfrom
andrey-git:py37
Jul 7, 2018
Merged

Add python 3.7 to travis and tox#14523
balloob merged 14 commits intohome-assistant:devfrom
andrey-git:py37

Conversation

@andrey-git
Copy link
Copy Markdown
Contributor

@andrey-git andrey-git commented May 18, 2018

Description:

Add python 3.7 to travis and tox

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@homeassistant homeassistant added small-pr PRs with less than 30 lines. cla-signed labels May 18, 2018
@andrey-git andrey-git changed the title Add python 3.7 to travis and tox [WIP] Add python 3.7 to travis and tox May 18, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented May 21, 2018

Looks like the PyYAML issue has been resolved but they are not pushing it to PyPi 🤔

@balloob
Copy link
Copy Markdown
Member

balloob commented Jun 26, 2018

PyYAML 4.1 with support for Python 3.7 got released today.

https://github.com/yaml/pyyaml/blob/master/CHANGES#L7

@ghost ghost assigned andrey-git Jul 7, 2018
@ghost ghost added the in progress label Jul 7, 2018
@andrey-git andrey-git requested a review from a team as a code owner July 7, 2018 07:27
@andrey-git
Copy link
Copy Markdown
Contributor Author

andrey-git commented Jul 7, 2018

Tests fail under 3.7 and it timeouts on 30 minutes. :(

@ghost ghost assigned balloob Jul 7, 2018
@balloob balloob changed the title [WIP] Add python 3.7 to travis and tox Add python 3.7 to travis and tox Jul 7, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Jul 7, 2018

Timing out of tests is because of my misunderstanding of how tearDown worked. It is only called if a test does not error out. That's why if a test fails, it usually goes crazy as we have all these other hass instances in memory, slowing things down.

I've went through the tests and pushed up some fixes 👍

@balloob
Copy link
Copy Markdown
Member

balloob commented Jul 7, 2018

I was forced to fix this as I got a new Mac and brew install python installed 3.7 😉

andrey-git
andrey-git commented Jul 7, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@andrey-git andrey-git left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two different versions of pexpect are now used.

@balloob balloob merged commit 02238b6 into home-assistant:dev Jul 7, 2018
@ghost ghost removed the in progress label Jul 7, 2018
awarecan pushed a commit to awarecan/home-assistant that referenced this pull request Jul 16, 2018
@andrey-git @awarecan
Add python 3.7 to travis and tox (home-assistant#14523)
80e48a3 
* Add python 3.7 to travis and tox

* Use pyyaml from github

* Don't version constraints

* Fix version tag

* Change to new pyyaml release

* Python 3.7 requires xenial

* Fix namespace detection

* Use correct RegEx type

* Update pexpect to 4.6

* Use correct validation for dictionaries

* Disable Py37 incompatible packages

* Upgrade all pexpect to 4.6

* Add explicit None as default param
@balloob balloob mentioned this pull request Jul 20, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@balloob balloob

@andrey-git andrey-git

Labels

cla-signed small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrey-git @balloob @homeassistant