Skip to content

Fix key error upon missing node #14460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvizeli merged 1 commit into from
May 14, 2018
Merged

Fix key error upon missing node #14460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions homeassistant/components/mysensors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,8 +495,9 @@ def mysensors_callback(msg):
_LOGGER.debug(
"Node update: node %s child %s", msg.node_id, msg.child_id)

child = msg.gateway.sensors[msg.node_id].children.get(msg.child_id)
if child is None:
try:
child = msg.gateway.sensors[msg.node_id].children[msg.child_id]
except KeyError:
Copy link
Copy Markdown
Member

@pvizeli pvizeli May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

child can also be None and that will not check anymore.

Copy link
Copy Markdown
Member Author

@MartinHjelmare MartinHjelmare May 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, child can not be None. The child id can be missing, but if it's not missing, the child instance is never None.

Copy link
Copy Markdown
Member

@pvizeli pvizeli May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I see you replace .get()

_LOGGER.debug("Not a child update for node %s", msg.node_id)
return

Expand Down