Fix key error upon missing node#14460
Merged
pvizeli merged 1 commit intoMay 14, 2018
Merged
Conversation
* This is needed after gateway ready message generates an update while persistence is off, or while the gateway node hasn't been presented yet.
homeassistant
added
cla-signed
integration: mysensors
small-pr
pvizeli
reviewed
May 14, 2018
| if child is None: | ||
| try: | ||
| child = msg.gateway.sensors[msg.node_id].children[msg.child_id] | ||
| except KeyError: |
Member
There was a problem hiding this comment.
child can also be None and that will not check anymore.
Member
Author
There was a problem hiding this comment.
No, child can not be None. The child id can be missing, but if it's not missing, the child instance is never None.
Member
There was a problem hiding this comment.
You are right, I see you replace .get()
pvizeli
approved these changes
May 14, 2018
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* This is needed after gateway ready message generates an update while persistence is off, or while the gateway node hasn't been presented yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Checklist:
tox. Your PR cannot be merged unless tests pass