Skip to content

Add 2 devices to Tohoma cover #14321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabaff merged 9 commits into from
May 8, 2018
Merged

Add 2 devices to Tohoma cover #14321

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
da60433
add 2 devices
m4dmin May 6, 2018
280462d
add 2 devices
m4dmin May 7, 2018
58904c3
Update tahoma.py
m4dmin May 7, 2018
23d263b
Fix hounci-bot violation
m4dmin May 7, 2018
38e9e34
Fixed Travis CI build failure
m4dmin May 7, 2018
72d17fb
Fixed Travis CI build failure
m4dmin May 7, 2018
3473106
Fixed Travis CI build failure
m4dmin May 7, 2018
0ba5139
Fix indent
fabaff May 8, 2018
b8b40fc
Change check
fabaff May 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions homeassistant/components/cover/tahoma.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,5 +81,9 @@ def stop_cover(self, **kwargs):
self.apply_action('setPosition', 'secured')
elif self.tahoma_device.type == 'rts:BlindRTSComponent':
self.apply_action('my')
elif self.tahoma_device.type == 'io:RollerShutterUnoIOComponent':

@balloob balloob May 7, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's the same command, please use a single if check:

elif self.tahoma_device.type in ('bla', 'bli', 'blub'):

self.apply_action('my')
elif self.tahoma_device.type == 'io:ExteriorVenetianBlindIOComponent':
self.apply_action('my')
else:
self.apply_action('stopIdentify')
2 changes: 2 additions & 0 deletions homeassistant/components/tahoma.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
'rts:CurtainRTSComponent': 'cover',
'rts:BlindRTSComponent': 'cover',
'rts:VenetianBlindRTSComponent': 'cover',
'io:ExteriorVenetianBlindIOComponent': 'cover',
'io:RollerShutterUnoIOComponent': 'cover',
'io:RollerShutterWithLowSpeedManagementIOComponent': 'cover',
'io:RollerShutterVeluxIOComponent': 'cover',
'io:RollerShutterGenericIOComponent': 'cover',
Expand Down