Add 2 devices to Tohoma cover#14321
Merged
fabaff merged 9 commits intohome-assistant:devfrom May 8, 2018
m4dmin:dev
Merged
Conversation
io:RollerShutterUnoIOComponent io:ExteriorVenetianBlindIOComponent
Contributor
homeassistant
added
cla-needed
integration: tahoma
platform: cover.tahoma
small-pr
balloob
previously requested changes
May 7, 2018
| self.apply_action('setPosition', 'secured') | ||
| elif self.tahoma_device.type == 'rts:BlindRTSComponent': | ||
| self.apply_action('my') | ||
| elif self.tahoma_device.type == 'io:RollerShutterUnoIOComponent': |
Member
There was a problem hiding this comment.
Since it's the same command, please use a single if check:
elif self.tahoma_device.type in ('bla', 'bli', 'blub'):
houndci-bot
reviewed
May 7, 2018
| self.apply_action('my') | ||
| else: | ||
| self.apply_action('stopIdentify') | ||
| self.apply_action('stopIdentify') No newline at end of file |
| self.apply_action('setPosition', 'secured') | ||
| elif self.tahoma_device.type == 'rts:BlindRTSComponent': | ||
| elif self.tahoma_device.type == 'rts:BlindRTSComponent' or \ | ||
| self.tahoma_device.type == 'io:ExteriorVenetianBlindIOComponent': |
There was a problem hiding this comment.
continuation line over-indented for visual indent
houndci-bot
reviewed
May 7, 2018
| self.apply_action('setPosition', 'secured') | ||
| elif self.tahoma_device.type == 'rts:BlindRTSComponent': | ||
| elif self.tahoma_device.type == 'rts:BlindRTSComponent' or \ | ||
| self.tahoma_device.type == 'io:ExteriorVenetianBlindIOComponent': |
There was a problem hiding this comment.
continuation line with same indent as next logical line
./homeassistant/components/cover/tahoma.py:83:13: E125 continuation line with same indent as next logical line
E125 continuation line with same indent as next logical line
houndci-bot
reviewed
May 7, 2018
| self.apply_action('setPosition', 'secured') | ||
| elif self.tahoma_device.type == 'rts:BlindRTSComponent': | ||
| elif self.tahoma_device.type == 'rts:BlindRTSComponent' or \ | ||
| 'io:ExteriorVenetianBlindIOComponent': |
There was a problem hiding this comment.
continuation line over-indented for visual indent
E127 continuation line over-indented for visual indent
Contributor
Author
|
Hello @balloob, I don't get it, I got stuck with an Travis CI build failure. Either I get "E127 continuation line over-indented for visual indent" or "E125 continuation line with same indent as next logical line", with following 2 lines of code: I tried many diffrent possiblities, but Travis CI always shows a failure with Python 2.5.2 TOXENV=lint... Best regards |
Contributor
Author
|
Many thanks for your help! |
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* add 2 devices io:RollerShutterUnoIOComponent io:ExteriorVenetianBlindIOComponent * add 2 devices * Update tahoma.py * Fix hounci-bot violation * Fixed Travis CI build failure ./homeassistant/components/cover/tahoma.py:83:13: E125 continuation line with same indent as next logical line * Fixed Travis CI build failure E125 continuation line with same indent as next logical line * Fixed Travis CI build failure E127 continuation line over-indented for visual indent * Fix indent * Change check
ghost
removed
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added two devices to tahoma:
io:RollerShutterUnoIOComponent
io:ExteriorVenetianBlindIOComponent
Related issue (if applicable): fixes #14318
Checklist: