Skip to content

Update efergy to add support for multiple channels #14286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daniel-stoneuk wants to merge 4 commits into from
Closed

Update efergy to add support for multiple channels #14286

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2733a43
Update efergy to add support for multiple channels
May 4, 2018
a99832c
Modified string concatenation to use formatting
May 5, 2018
14f4067
Use string formatting
fabaff May 8, 2018
4d055cd
Revert changes (needs update of tests too)
fabaff May 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions homeassistant/components/sensor/efergy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
+ app_token
response = get(url_string, timeout=10)
for sensor in response.json():
sid = sensor['sid']
sid = sensor['sid']+'_'+sensor['cid']

@fabaff fabaff May 5, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use string formatting.

dev.append(EfergySensor(variable[CONF_SENSOR_TYPE], app_token,
utc_offset, variable[CONF_PERIOD],
variable[CONF_CURRENCY], sid))
Expand Down Expand Up @@ -143,7 +143,7 @@ def update(self):
+ self.app_token
response = get(url_string, timeout=10)
for sensor in response.json():
if self.sid == sensor['sid']:
if self.sid == sensor['sid']+'_'+sensor['cid']:

@fabaff fabaff May 5, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dito

measurement = next(iter(sensor['data'][0].values()))
self._state = measurement
else:
Expand Down