Update efergy to add support for multiple channels#14286
Closed
daniel-stoneuk wants to merge 4 commits intohome-assistant:devfrom
Closed
Update efergy to add support for multiple channels#14286daniel-stoneuk wants to merge 4 commits intohome-assistant:devfrom
daniel-stoneuk wants to merge 4 commits intohome-assistant:devfrom
Conversation
Fix for the issue I pointed out [here](https://community.home-assistant.io/t/efergy-2-or-more-sensors/10638/22?u=daniel-stoneuk) about a year ago. Adds support for solar installations using Eco-Eye or Wattson energy monitors
This comment has been minimized.
This comment has been minimized.
homeassistant
added
platform: sensor.efergy
small-pr
fabaff
reviewed
May 5, 2018
| response = get(url_string, timeout=10) | ||
| for sensor in response.json(): | ||
| sid = sensor['sid'] | ||
| sid = sensor['sid']+'_'+sensor['cid'] |
fabaff
reviewed
May 5, 2018
| response = get(url_string, timeout=10) | ||
| for sensor in response.json(): | ||
| if self.sid == sensor['sid']: | ||
| if self.sid == sensor['sid']+'_'+sensor['cid']: |
Applied to changes & elsewhere
Author
|
I have changed the edits that I've made to use string formatting however there are other elements of the component that do not use string formatting - is this okay? |
Member
|
This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it. |
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix for the issue I pointed out here about a year ago. Adds support for solar installations using Eco-Eye or Wattson energy monitors. Changed entity id to include energy channel.
No documentation changes are applicable however entity id's will be different therefore it's a breaking change.
Checklist:
tox.