Template Sensor add device_class support#14034
Merged
balloob merged 3 commits intohome-assistant:devfrom May 1, 2018
Merged
Conversation
houndci-bot
reviewed
Apr 21, 2018
|
|
||
| from homeassistant.core import callback | ||
| from homeassistant.components.sensor import ENTITY_ID_FORMAT, PLATFORM_SCHEMA | ||
| from homeassistant.components.sensor import ENTITY_ID_FORMAT, PLATFORM_SCHEMA, \ |
There was a problem hiding this comment.
line too long (80 > 79 characters)
2 tasks
Member
Author
|
Tests have been added :) |
balloob
approved these changes
May 1, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Sensor now can have device classes too (see #14010) and AFAIK they're now the recommended to use instead of the old
icon:configuration option.Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5220
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: