Conversation
homeassistant
added
cla-signed
integration: sensor
core
platform: sensor.linux_battery
small-pr
Member
|
We could also use this to group data for data collectors like influxdb and datadog. Limitation is that the device class isn't available per state attribute. |
Contributor
|
Just checking: this will impact history panel only for now ? |
Member
Author
|
It will impact nothing yet because history panel has not been updated yet. |
pvizeli
approved these changes
Apr 20, 2018
Member
pvizeli
left a comment
pvizeli
left a comment
There was a problem hiding this comment.
That is a cool idea to cleanup/sort all this sensor data
This was referenced Apr 21, 2018
Merged
ghost
added
integration: ecobee
integration: linux_battery
integration: nest
and removed
platform: sensor.ecobee
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
We should add device classes to sensors, just like we have for binary sensors.
Previously, we would try to distinguish / group sensors by unit of measurement in, for example, the history panel in the frontend. However, this can result in a graph that contains both battery levels and humidity (both %).
As an example, I've updated 3 sensors.
We will update the frontend to recognize device classes for sensors and automatically assign icons.
I think that we should be a little conservative in adding device classes. We should only add them for the ones that are common.