Skip to content

Upgrade pylutron-caseta to 0.5.0 to reestablish connections#14013

Merged
pvizeli merged 2 commits intohome-assistant:devfrom
rohankapoorcom:upgrade-pylutron-caseta
Apr 20, 2018
Merged

Upgrade pylutron-caseta to 0.5.0 to reestablish connections#14013
pvizeli merged 2 commits intohome-assistant:devfrom
rohankapoorcom:upgrade-pylutron-caseta

Conversation

@rohankapoorcom
Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom commented Apr 20, 2018

Description:

Something changed on the lutron end of things and pylutron_caseta was unable to connect to the caseta bridge. This was fixed upstream in (see links below) but the library was not upgraded in home assistant.

No configuration changes were needed in home assistant to make this work.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@mhofman
Copy link
Copy Markdown

mhofman commented Apr 20, 2018

Since the new caseta protocol seems to change the previously reported entity_id, wouldn't this be a good opportunity to add support for the entity registry, and avoid future break of entity names?

@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Apr 20, 2018

We can do this in a future PR @mhofman

@pvizeli pvizeli merged commit 8459b24 into home-assistant:dev Apr 20, 2018
@cgarwood
Copy link
Copy Markdown
Member

Since its reported to change entity_id's should it be marked as a breaking change?

@rohankapoorcom
Copy link
Copy Markdown
Member Author

@mhofman any documentation on integrating components onto the component registry? Happy to give it a shot for this one.

@mdonoughe
Copy link
Copy Markdown
Contributor

Apparently the name change is actually due to gurumitts/pylutron-caseta#20. The component registry will fix it anyway. Unfortunately, it looks like we will need to change pylutron-caseta again to include more device information including the serial numbers so we have something to match against in the registry.

@mdonoughe
Copy link
Copy Markdown
Contributor

I opened #14037 which will hopefully get the entity registry working once gurumitts/pylutron-caseta#25 is available.

@mdonoughe
Copy link
Copy Markdown
Contributor

Do we still need to update the documentation? The old script to get the certificates still gets the certificates but reports an error at the end when it tries to verify the connection. There's an updated version in the pylutron-caseta repo.

@rohankapoorcom rohankapoorcom deleted the upgrade-pylutron-caseta branch April 25, 2018 04:06
@balloob balloob mentioned this pull request Apr 27, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants